1
0
mirror of https://github.com/OpenRCT2/OpenRCT2 synced 2026-01-16 11:33:03 +01:00
Commit Graph

163 Commits

Author SHA1 Message Date
Matt
b071be49bd Add checks for unregistered game actions and report errors. 2019-02-07 18:35:03 +01:00
duncanspumpkin
5e319a4a37 Increment network version 2019-02-07 10:16:20 +00:00
Duncan
b27923093c Fix #7987: Broken track designs increase money by MONEY32_UNDEFINED 2019-02-06 22:20:42 +01:00
duncanspumpkin
752df2607a Increment network version 2019-02-05 20:39:53 +00:00
Christopher G. Dolan
19a58fa5fe Fix format, move validation logic to query, update network version 2019-02-04 17:30:45 -08:00
Michał Janiszewski
604da7ce01 Merge pull request #8661 from tomlankhorst/refactor-random
Refactor random engine
2019-02-03 23:29:10 +01:00
Tom Lankhorst
16691b22ba Use state struct 2019-02-01 19:29:43 +01:00
Tom Lankhorst
6a42a95495 Refactor random engine
Introduce RotateEngine and Rct2Engine, FixedSeedSequence and Rct2Seed.
Adhere respectively to requirements `RandomNumberEngine` and `SeedSequence`.
Can be used with C++11 adaptors and distributions in <random>.
2019-02-01 14:32:04 +01:00
Matt
4026ead774 Fix #8653: crash when peeps attempt to enter a ride with no vehicles. 2019-01-30 13:16:45 +01:00
Tom Lankhorst
0233795add Fix #8642: Likely mistake in entrance fee check 2019-01-28 11:15:49 +01:00
Michael Steenbeek
247e89eb53 Revert duck fix 2019-01-24 10:40:04 +01:00
deurklink
5e39147b76 Fix #8584: Ducks spawning function doesnt check tiles 0..63 (original bug) (#8614) 2019-01-20 13:20:01 +01:00
ζeh Matt
a34422dc26 Fix #8591: Game loop does not run at a consistent tick rate of 40 Hz (#8594)
* Fix #8591: Run game loop at consistent tick rate of 40hz.

* Update distribution/changelog.txt

Co-Authored-By: ZehMatt <m.moninger.h@gmail.com>
2019-01-17 23:22:27 +01:00
deurklink
51fc2fe84a Feature #8583: Add booster pieces for water coaster
Co-Authored-By: deurklink
2019-01-14 22:17:52 +01:00
Michał Janiszewski
0d2fd33fd8 Bump network version
Co-Authored-By: ZehMatt <m.moninger.h@gmail.com>
2019-01-07 09:04:51 +01:00
Michał Janiszewski
c5e1abcfb1 Fix implicit fallthroughs 2019-01-02 22:30:57 +01:00
Matt
6e2514cd0d Refactor sprite_checksum, returns rct_sprite_checksum now. 2018-12-29 19:23:27 +01:00
Michael Steenbeek
2530cd1ac3 Fix #8426: Queue banner left behind after ride demolition 2018-12-22 15:34:17 +01:00
Michael Steenbeek
65dcdf77ea Fix #8508: Underground roto-drop is not going up 2018-12-22 11:56:00 +01:00
ζeh Matt
b572fffafa Merge pull request #8457 from ZehMatt/refactor/game-action-name
Automatically expose game action name via macro.
2018-12-20 23:17:49 +01:00
Matt
4ff2dbd108 Automatically expose game action name via macro. 2018-12-20 22:20:58 +01:00
ζeh Matt
7568123a9d Fix #8482: Pending player list not being reset. (#8483) 2018-12-19 20:34:41 +01:00
ζeh Matt
183e508c4d Merge pull request #8465 from ZehMatt/fix-8464
Fix #8464: Crash on game shutdown.
2018-12-18 00:55:22 +01:00
Michał Janiszewski
ea61be5ebe Prevent logging from using already-freed game command (#8473)
gc variable is held by reference in the scope above, pointing to the
queue's beginning.
2018-12-17 23:56:01 +01:00
Matt
8e2e60b117 Fix #8464: Crash on game shutdown. 2018-12-17 23:51:43 +01:00
ζeh Matt
7d19a5bc77 Refactor memcpy to std::memcpy and memset to std::memset (#8408) 2018-12-15 22:23:31 +01:00
Gymnasiast
748da25f78 Fix omission from #8453 2018-12-15 21:34:14 +01:00
Gymnasiast
600d32807d Fix #8033: Crash when placing 64th sign 2018-12-15 20:34:28 +01:00
Michael Steenbeek
cf44ea7e24 Fix #3832: Track piece colour scheme paint not network-safe 2018-12-11 22:17:52 +01:00
roosen5
d9806305b0 Fix #8358: infinite loop when changing vehicle count on stopped ride. (#8375)
The sprite_remove in Sprite.cpp tries to find itself inside the quadrant.
It does not find itself, and because the rest of the code assumes that it will always find it
The normal code tries to set the value of the next_in_quadrant so that whoever points at it, will now point at its next sprite.
But because it didn't find whoever was pointing to it, it would set the pointer to SPRITE_INDEX_NULL to its next sprite.
This would lead to cycles in the linked list

The reason that the sprite was not found is that during the entry of a ride, the position of a peep is set to LOCATION_NULL
Exiting a ride sets it back to whatever the location is of an exit.
However stopping a ride that still has people in it would go wrong, as the people are removed from the ride through ride_remove_peeps

This function was called during the PaintWindows.
The fact that this function is called during the painting is the problem, because of the tweening:
Before painting all the positions are stored (Which would at that point be the LOCATION_NULL), during the painting
the peep would be removed from the ride, setting their location to the enrance/exit
After painting is done all the positions are restored again, so the patched position is forgotten and then it would be
removing a sprite with location LOCATION_NULL and that goes wrong

The fix is to have the window update outside of paint
2018-12-09 20:46:04 +01:00
ζeh Matt
04af3932ac Fix #5684: Refactor player list updates being bound on ticks. (#8399) 2018-12-09 20:39:44 +01:00
Michael Steenbeek
a9a583dcd1 Fix #8200: Incorrect behaviour when removing entrances/exits on the same tile 2018-11-27 22:59:31 +01:00
Hielke Morsink
354d973a48 Use std::size instead of Util::CountOf 2018-11-23 21:59:08 +01:00
ζeh Matt
1abb31a159 Implement game action logging. (#8138) 2018-11-20 06:04:42 +01:00
Michał Janiszewski
0d2751a54e Hide the network class declaration to Network.cpp (#8276)
The Network class is not used by anyone other than free functions in
Network.cpp, nor should it be used by anyone with the current design.

This change leaves only the publicly-exposed functions left in the
header, drastically reducing amount of required headers in network.h,
one of the heaviest headers we had so far.
2018-11-19 23:10:54 +01:00
Michael Steenbeek
82aba96728 Cheats: use 'weather' instead of 'climate' (#8246) 2018-11-10 14:30:41 +01:00
Hielke Morsink
107faaf821 Add and use game action for setting the climate
Also reordered the registered game actions the same as headers, so they are easier to find.
2018-11-08 22:39:13 +01:00
Michael Steenbeek
df768a3fad Fix #8201: Only quarter scenery objects in one corner can be painted 2018-11-05 20:12:22 +01:00
Felix Pelletier
0cd7f1e07c Fix #8142: Reliability of unbreakable rides can go below 100% 2018-11-02 09:04:27 +01:00
Michael Steenbeek
f55f323723 Allow building footpaths on 'corner down' terrain 2018-11-01 11:04:32 +01:00
Michael Steenbeek
a8f526ae48 Allow on-ride photos and water S-bends on the Water Coaster 2018-11-01 10:12:45 +01:00
Hielke Morsink
698426dad7 Increase network version to avoid conflicts (#8194)
#8053 bumped the network version to 3, which we already had before but was reverted.
2018-10-31 20:47:35 +01:00
Michael Steenbeek
687fbc2a0a Modify game_command_set_scenery_colour() to only take the scenery quadrant 2018-10-31 13:10:26 +01:00
Michael Steenbeek
15490010e1 Revert "Fix #8064: Prohibited high construction error is sometimes shown as (undefined string)"
This reverts commit a8e46f5eec.
2018-10-23 14:52:51 +02:00
ζeh Matt
a8e46f5eec Fix #8064: Prohibited high construction error is sometimes shown as (undefined string) 2018-10-21 20:51:41 +02:00
Berbe
102a2ee234 Add player hash to server log message on join (#7946) 2018-10-15 21:40:22 +02:00
Michael Steenbeek
28e8b4e12b Modify game_command_remove_scenery to take unshifted scenery quadrant 2018-10-03 12:31:02 +02:00
deurklink
a5cbcb448c Fix #7975: Clear inspection due flag when interval set to Never 2018-09-07 13:08:26 +02:00
Matt
8c6f6a18ab Remove unused passing of object manager. 2018-08-31 07:18:50 +02:00
Matt
04928d4b84 Refactor reference over std::shared_ptr. 2018-08-31 07:18:48 +02:00