duncanspumpkin
bb042213fd
Fix #10069 . Actually pass the track element flags to the new element.
...
Mistake made whilst refactoring #10058 . Flags were incorrectly been taken from the destination and not the source.
Refactored names to use the correct t number
2019-10-10 18:48:05 +01:00
Denis Khabenkov
57a208d560
Fix #10064 : Refactor TrackDesignEntranceElement ( #10066 )
...
* Fix #10064 : Refactor TrackDesignEntranceElement
2019-10-10 18:23:29 +01:00
Tulio Leao
b793d7e79a
Avoid dereferencing map_get_first_element_at nullptr on libopenrct2 ( #10013 )
...
* Avoid dereferencing map_get_first_element_at nullptr on Map.cpp
* Avoid dereferencing map_get_first_element_at nullptr on MapAnimation.cpp
Returning true or internal control variable, based on what was seen on `map_animation_invalidate_track_onridephoto`
* Avoid dereferencing map_get_first_element_at nullptr on Park.cpp
* Avoid dereferencing map_get_first_element_at nullptr on Scenery.cpp
* Avoid dereferencing map_get_first_element_at nullptr on Sprite.cpp
* Avoid dereferencing map_get_first_element_at nullptr on TileInspector.cpp
* Avoid dereferencing map_get_first_element_at nullptr on Wall.cpp
* Avoid dereferencing map_get_first_element_at nullptr on Fountain.cpp
* Avoid dereferencing map_get_first_element_at nullptr on Footpath.cpp
* Avoid dereferencing map_get_first_element_at nullptr on Entrance.cpp
* Avoid dereferencing map_get_first_element_at nullptr on Banner.cpp
* Avoid dereferencing map_get_first_element_at nullptr on Vehicle.cpp
* Avoid dereferencing map_get_first_element_at nullptr on TrackDesignSave.cpp
* Avoid dereferencing map_get_first_element_at nullptr on TrackDesign.cpp
* Avoid dereferencing map_get_first_element_at nullptr on Track.cpp
* Avoid dereferencing map_get_first_element_at nullptr on Station.cpp
* Avoid dereferencing map_get_first_element_at nullptr on RideRatings.cpp
* Avoid dereferencing map_get_first_element_at nullptr on Ride.cpp
* Avoid dereferencing map_get_first_element_at nullptr on S4Importer.cpp
* Avoid dereferencing map_get_first_element_at nullptr on Staff.cpp
* Avoid dereferencing map_get_first_element_at nullptr on Peep.cpp
* Avoid dereferencing map_get_first_element_at nullptr on GuestPathfinding.cpp
* Avoid dereferencing map_get_first_element_at nullptr on Guest.cpp
* Avoid dereferencing map_get_first_element_at nullptr on VirtualFloor.cpp
* Avoid dereferencing map_get_first_element_at nullptr on Paint.TileElement.cpp
* Fix issues raised on review
* Fix remaining review issues.
* Early exit on loops if tileElement is nullptr
* Fix clang-format issues
2019-10-09 15:02:21 +01:00
Tulio Leao
3f21933d5b
Fix clang-format issue.
2019-10-08 18:22:02 -03:00
Tulio Leao
121585578e
Remove implicit conversion constructor
2019-10-08 18:22:02 -03:00
Tulio Leao
7193ba1bb7
Create TrackDesignMazElement struct
...
Closes #10053
2019-10-08 18:21:58 -03:00
Tulio Leao
6be7c42a3d
Close #10051 : Create TrackDesignSceneryElement
2019-10-08 17:13:34 +02:00
ζeh Matt
dd6d028c5b
Merge pull request #10061 from tupaschoal/nullptr-deref-consistency
...
Make check for map_get_nth_element_at consistent
2019-10-08 17:08:52 +02:00
Tulio Leao
4a817b88d9
Make check for map_get_nth_element_at consistent
...
Most places compare to `nullptr` explicitly, thus changed the ones that didn't.
Also moved one call that might have been superfluous if `offset == 0`
2019-10-08 08:06:46 -03:00
Tulio Leao
68ce43308e
Remove implicit conversion constructor
2019-10-08 07:48:03 -03:00
Tulio Leao
ff57f43996
Create TrackDesignTrackElement struct
...
Closes #10054
2019-10-08 07:47:56 -03:00
Duncan
ee0025987a
Merge pull request #10056 from duncanspumpkin/refactor
...
Refactor
2019-10-08 09:26:43 +01:00
Denis Khabenkov
163221520b
Delete assert and size information
2019-10-07 22:26:16 +03:00
Denis Khabenkov
de53ac84b8
Fix #10052 : Create a TrackDesignEntranceElement struct to replace rct_td6_entrance_element
2019-10-07 21:59:07 +03:00
duncanspumpkin
2c5ff4a0d1
Rename variables
2019-10-07 18:56:31 +01:00
duncanspumpkin
213ba15ba5
Remove unused code and variables from function
2019-10-07 18:36:27 +01:00
duncanspumpkin
f10e4dc6b9
Remove unused variables from function call
2019-10-07 18:33:51 +01:00
Matt
884611c20b
Bump up network version
2019-10-05 13:13:44 +02:00
Matt
0c11bbd4e7
Fix #9994 : Game action tick collision during server connect and map load
2019-10-05 13:09:21 +02:00
ζeh Matt
e4a2b1f9c5
Fix #9953 : Crash when hacked rides attempt to find the closest mechanic
2019-10-03 23:08:40 +02:00
Gymnasiast
db5c018e22
Add requested check
2019-10-03 22:26:08 +02:00
crorvig
7f54ba0be7
Set BuildInPauseMode to true during map_remove_out_of_range_elements()
...
Set BuildInPauseMode to true during map_remove_out_of_range_elements()
2019-10-03 22:26:08 +02:00
crorvig
ed1dfa39c2
Fix #9955 Allow resizing of map in pause mode
...
Prevents infinite loop by forcing BuildInPauseMode on for the duration
of the map_remove_out_of_range_elements() call.
2019-10-03 22:26:08 +02:00
ζeh Matt
a39bd39268
Fix #10036 : Do not allocate large chunks of memory for save file classification ( #10040 )
2019-10-03 17:36:58 +02:00
ζeh Matt
0b95dcd0d0
Fix #8584 : Duck spawn search now uses entire map ( #9743 )
2019-10-02 22:14:56 +02:00
Ted John
15767c3be3
Fix output result of remove_unused_objects ( #10029 )
2019-10-01 22:30:11 +02:00
Michael Steenbeek
a63395eb1c
Fix #10028 : Saved park--brakes all set to 0mph
2019-09-29 22:53:41 +02:00
aw20368
ff1698bcb9
Improve #9987 : Minimum load rounding ( #9987 )
...
Refactor code for vehicles waiting for a specific load level.
Original code rounded the target load down, changed to round up.
2019-09-28 20:51:13 +02:00
ζeh Matt
b82d1bbc64
Fix #10015 : Crash when certain images are drawn ( #10016 )
2019-09-23 22:37:28 +02:00
ζeh Matt
b2a42de579
Fix ghost elements influencing ride excitement
2019-09-23 22:36:51 +02:00
Jan Beich
a5555649ec
network: unbreak build with Clang 9 ( #10014 )
...
ld: error: libopenrct2.a(Network.cpp.o): unable to find library from dependent library specifier: Ws2_32.lib
2019-09-23 17:14:57 +02:00
Gymnasiast
856075a781
Bump network version and amend changelog
2019-09-22 23:07:57 +02:00
aw20368
3f10811426
Fix #9970 : Wait for quarter load fails
...
Vehicle was always incorrectly flagged as ready to depart when quarter load is selected. Removed erroneous flag.
2019-09-22 23:06:54 +02:00
Michael Steenbeek
5e1d14f061
Merge pull request #9939 from IntelOrca/refactor/image-id
...
Create new ImageId struct
2019-09-22 17:07:49 +02:00
Michael Steenbeek
a5700a3d07
Merge pull request #9959 from richard-fine/directions
...
Convert more code to use proper Direction symbols
2019-09-22 16:59:41 +02:00
gill984
565ad3798d
Fix #9957 : Guests complain about running out of money in no money parks
2019-09-22 16:52:53 +02:00
Joseph Atkins-Turkish
2e5f46fcf1
Fix raise/lowering water at edge of map ( #9979 )
2019-09-22 14:13:52 +02:00
Michael Steenbeek
a11762b11a
Remove old C functions that only call their equivalent
...
* Remove old C functions that only call their equivalent
* fix formatting
2019-09-22 14:12:49 +02:00
Duncan
b94b8880aa
Fix ride station index related bugs
2019-09-19 22:56:54 +02:00
Joseph Atkins-Turkish
747e00512d
Fix #7572 : Queue paths connect to regular paths through fences
2019-09-18 23:31:29 +02:00
Peter
650142de9b
Fix #9902 : Doors and portcullises can be double opened
2019-09-18 23:26:33 +02:00
Joseph Atkins-Turkish
6b21aac4ea
Fix #9675 : Inconsistent number of guest entry points ( #9990 )
2019-09-15 18:57:21 +02:00
Gymnasiast
0aca04256b
Fix #9978 : Mazes are imported incorrectly
2019-09-12 23:12:54 +02:00
Michael Steenbeek
4424964686
Fix #9975 and #9976 : Crash when removing LargeScenery with null element ( #9977 )
2019-09-10 21:03:22 +02:00
ζeh Matt
afda556e86
Merge pull request #9915 from ZehMatt/audio-music-limit
...
#1349 : Increase the number of ride music played simultaneously to 32
2019-09-10 13:02:29 +02:00
Gymnasiast
673b12029e
Bump network version
2019-09-09 23:07:46 +02:00
Michael Steenbeek
d314782a40
Merge pull request #9952 from Gymnasiast/refactor/use-that-space
...
Refactor/use that space
2019-09-09 19:05:50 +02:00
Ted John
fc679c9105
Fix #9956 : invalid-read in window_ride_main_open
2019-09-08 13:55:02 +01:00
Ted John
7b7d3ec5e3
Fix #9971 : invalid-read in place_virtual_track
2019-09-08 13:45:56 +01:00
Richard Fine
92f50efedc
Formatting fixes
2019-09-01 19:10:27 +01:00