* Part of #21421: Refactor RIDE_INITIAL_RELIABILITY in Ride.h
* Part of #21421: Refactor STATION_DEPART_FLAG and STATION_DEPART_MASK
* Part of #21421: Refactor MAX_STATION_PLATFORM_LENGTH
* Part of #21421: Refactor RIDE_RATING_UNDEFINED
* Part of #21421: Refactor TRACK_BLOCK_END
* Part of #21421: Refactor TRACK_PREVIEW_IMAGE_SIZE
* Part of #21421: Refactor based on feedback
* Part of #21421: Fix signed/unsigned mismatch on Win
* Improved consistency kTrackPreviewImageSize
Co-authored-by: Michael Steenbeek <m.o.steenbeek@gmail.com>
* Part of #21421: kMaxStationPlatformLength to int8
---------
Co-authored-by: Michael Steenbeek <m.o.steenbeek@gmail.com>
* Add `STR_ERR_CANT_CHANGE_PARK_ENTRANCE_FEE`
* Add `STR_ERR_TRACK_ON_THIS_TILE_NEEDS_WATER`
* Return existing `GameAction::Result`
* Add `STR_ERR_ACTION_INVALID_FOR_THAT_STAFF_TYPE`
I am open to suggestions for a different message!
Originally this was going to be STR_ERR_WRONG_STAFF_TYPE
but I thought that was confusing because the game
action arguments do not specify a staff type. We
want it to mean "the staff ID you specified is the
wrong StaffType for this game action".
* Refactor `StaffSetColour()` to return `Result`
* Remove unnecessary arguments when `Status` is `Ok`
* Refactor `SwapTileElements()` to return `Result`
Also add STR_ERR_CANT_SWAP_TILE_ELEMENT_WITH_ITSELF
* Format code
* Use `STR_ERR_CANT_CHANGE_PARK_ENTRANCE_FEE` in title
* Format code using Github web editor
* Format indentation
Also changed a few instances where GetGameState was called inside the same function.
The change in Peep.cpp is needed because of a function conflict. FormatStringID exists both in the global and in the OpenRCT2 namespace.
* Use money64 for ride prices and shop items
* Use money64 for park entrance fee
* Use money64 for gGuestInitialCash
* Use money64 for upkeep costs
* Use money64 for ride value
* Use money64 for marketing campaign cost
* Use money64 for object prices
* Use money64 for land prices
* Use money64 for guest expenditure
* Replace remaining occurrences of money32 with money64
* Update replays
* Bump network version
---------
Co-authored-by: duncanspumpkin <duncans_pumpkin@hotmail.co.uk>
* Add object entry manager
Port over wall and banner
* Port over small scenery to ObjectEntryManager
Clang format files
Actually make things safe
Fix build