mirrors/OpenTTD
1
0
Fork 0
mirror of https://github.com/OpenTTD/OpenTTD synced 2025-12-10 06:52:05 +01:00
Code Issues Releases Wiki Activity

Codefix: Remove this-> from static call to CleaningPool. (#14817)

Browse Source 
Don't call unnecessarily.
This commit is contained in:
Peter Nelson
2025-11-23 21:37:43 +00:00
committed by GitHub
parent 7ffd3b2c48
commit c9b73247e0
3 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/economy.cpp
View File

@@ -1181,7 +1181,7 @@ CargoPayment::CargoPayment(Vehicle *front) :
CargoPayment::~CargoPayment() CargoPayment::~CargoPayment()
{ {
if (this->CleaningPool()) return; if (CleaningPool()) return;
this->front->cargo_payment = nullptr; this->front->cargo_payment = nullptr;

2
src/roadstop.cpp
View File

@@ -30,8 +30,6 @@ RoadStop::~RoadStop()
if (this->status.Test(RoadStopStatusFlag::BaseEntry)) { if (this->status.Test(RoadStopStatusFlag::BaseEntry)) {
delete this->entries; delete this->entries;
} }
if (CleaningPool()) return;
} }
/** /**

8
src/story.cpp
View File

@@ -39,10 +39,10 @@ INSTANTIATE_POOL_METHODS(StoryPage)
StoryPage::~StoryPage() StoryPage::~StoryPage()
{ {
if (!this->CleaningPool()) { if (CleaningPool()) return;
for (StoryPageElement *spe : StoryPageElement::Iterate()) {
if (spe->page == this->index) delete spe; for (StoryPageElement *spe : StoryPageElement::Iterate()) {
} if (spe->page == this->index) delete spe;
} }
} }