1
0
mirror of https://github.com/OpenTTD/OpenTTD synced 2026-02-02 17:11:20 +01:00

Fix #13002: Crash due to use of dangling types in picker GUI used/saved lists (#13008)

This commit is contained in:
Jonathan G Rennison
2024-10-20 09:37:17 +01:00
committed by GitHub
parent 582f37dc15
commit 3105f6391c

View File

@@ -197,10 +197,14 @@ void PickerWindow::ConstructWindow()
this->classes.SetSortFuncs(_class_sorter_funcs);
this->classes.SetFilterFuncs(_class_filter_funcs);
/* Update saved type information. */
this->callbacks.saved = this->callbacks.UpdateSavedItems(this->callbacks.saved);
/* Clear used type information. */
this->callbacks.used.clear();
if (this->has_type_picker) {
/* Update used and saved type information. */
this->callbacks.saved = this->callbacks.UpdateSavedItems(this->callbacks.saved);
this->callbacks.used.clear();
/* Populate used type information. */
this->callbacks.FillUsedItems(this->callbacks.used);
SetWidgetDisabledState(WID_PW_MODE_ALL, !this->callbacks.HasClassChoice());