1
0
mirror of https://github.com/OpenRCT2/OpenRCT2 synced 2026-01-15 11:03:00 +01:00
Commit Graph

22497 Commits

Author SHA1 Message Date
Gymnasiast
afa4c906c5 Rename members of VehicleSound 2025-10-01 20:34:55 +02:00
Gymnasiast
7a0f201899 Rename members of Sound 2025-10-01 20:34:54 +02:00
Gymnasiast
4158ddfe11 Change CheatType to lowerCamelCase 2025-10-01 20:34:54 +02:00
Michael Steenbeek
d746da1d9a Fix: Log Flume lift sound does not loop 2025-10-01 20:34:06 +02:00
Silent
4029254263 JobPool: Simplify lock guard objects (#25281) 2025-10-01 08:13:53 +02:00
Matt
f21af599cd Merge pull request #25278 from ZehMatt/use-after-move
RideList.cpp: Don't use the variable after it is moved
2025-09-28 22:13:54 +03:00
Michał Janiszewski
39153b5051 Fix multithreaded access to additional crash files (#25271)
`GetScenarioInfo` can be called from a `JobPool` in `FileIndex::Build`,
resulting in multiple threads trying to access the `_uploadFiles` map
for breakpad.

This commit adds a mutex guard for `_uploadFiles` and provides unique
names for the entries.

The crash handler itself does not verify mutex state, possibly causing
data races, but I don't think it's safe to access it at this point and
we have to make do with whatever state is present at this point.
2025-09-28 21:01:36 +02:00
ζeh Matt
8fbb649cc9 Don't use the variable after it is moved 2025-09-28 21:39:55 +03:00
ζeh Matt
43f7d2d912 Fix logicalCmp not sorting in natural order, refactor the entire thing 2025-09-27 20:21:30 +03:00
ζeh Matt
3bf75a1bc1 Make unknown satisfaction go at the bottom when sorted by highest 2025-09-27 20:21:30 +03:00
ζeh Matt
5c693e56d6 Make unknown popularity go at the bottom when sorted by highest 2025-09-27 20:21:30 +03:00
ζeh Matt
8a6d855edd Fix #25201: Unstable sorting of the ride list 2025-09-27 20:21:26 +03:00
matheusvb3
4bd911b472 Fix chance of thunder effects being lower than vanilla 2025-09-25 18:33:07 +00:00
Aaron van Geffen
9019f00039 Split off WindowFootpathUpdateModifierKeyState to its own function 2025-09-25 19:27:26 +02:00
ZeeMaji
1af0874443 Revert crooked house & circus default prices to vanilla values 2025-09-25 08:51:43 +00:00
spacek531
d5035726ee Rename sound_vector_factor to dopplerShift 2025-09-24 23:13:03 +02:00
Aaron van Geffen
f289cd3e79 Make frozen guests no longer finish food or drinks (#25251) 2025-09-24 17:02:43 +00:00
Michael Steenbeek
a73bf7a2c7 Split CLI commands into their own files (#25241) 2025-09-24 15:43:25 +02:00
Michael Steenbeek
af8e6bb234 Merge pull request #25239 from Gymnasiast/refactor/no-repository-in-loading-code
Remove ObjectRepository from object reading code
2025-09-24 12:19:57 +02:00
Gymnasiast
a03613df35 Change FilterPaletteID to lowerCamelCase 2025-09-23 21:09:54 +02:00
Gymnasiast
c3ac626cd5 Update kTranslucentWindowPalettes name, replace defines 2025-09-23 21:03:57 +02:00
Aaron van Geffen
253d8484bf Make S4Importer::CorrectRCT1ParkValue independent of global game state (#25178) 2025-09-23 19:40:27 +02:00
Gymnasiast
73f31b707b Pass car by reference 2025-09-23 18:33:42 +02:00
Spacek531
e656602f83 Convert legacy sprite groups to FlagHolder 2025-09-23 18:33:42 +02:00
Michael Steenbeek
744c1fd5a3 Fix #25207: No switch to block sectioned mode after building one on the LIM LRC 2025-09-23 17:34:38 +02:00
Michał Janiszewski
41dd05ea43 Include crashing scenario in breakpad upload (#25204)
Fixes missing park for #25202
2025-09-23 15:40:46 +02:00
Gymnasiast
04af97ec74 Remove repository from IReadObjectContext, ObjectFileIndex and helper functions 2025-09-23 14:10:07 +02:00
Gymnasiast
f768d2873e Do not read from repository when loading objects 2025-09-23 14:09:09 +02:00
Michael Steenbeek
3e11a8efdf Fix #24998: Some custom small scenery objects do not load 2025-09-23 14:06:20 +02:00
Gymnasiast
73d3e4f0e3 Change "sprite exportalldat" into "sprite exportobject", take a filename instead of an already loaded DAT 2025-09-21 21:18:59 +02:00
Gymnasiast
161a8359fc Create function to create object from file 2025-09-21 21:18:22 +02:00
Aaron van Geffen
db5f56f4aa Scripting: order available costumes array by display name (#25228) 2025-09-21 15:31:36 +00:00
matheusvb3
72c6908cf0 Check if we're in shop tab before drawing track design info 2025-09-21 17:06:12 +02:00
Michael Steenbeek
eb38b7227f Change WindowFlag to strong enum 2025-09-20 21:46:42 +02:00
matheusvb3
f60dac165f Don't print the trailing comma in sprite exportalldat JSON output 2025-09-20 13:35:53 +02:00
spacek531
e5aa3b33f2 Use regular interval for swing sprite threshold (#25171)
* use regular interval for swing sprite threshold

* bump network

* bump park file version
2025-09-20 09:39:50 +02:00
Aaron van Geffen
80badee58d Skip drawing accessories whilst peep is clapping 2025-09-20 00:11:47 +02:00
Michael Steenbeek
77d330a004 Merge pull request #25205 from Gymnasiast/refactor/more-code-style-b
Refactor more UI code style
2025-09-19 16:15:30 +02:00
Aaron van Geffen
1d956b6dfb Pass ParkData& to scenario objective checks (#25209) 2025-09-19 12:51:17 +02:00
Aaron van Geffen
f5faef7bea Scenery window: increase minimum height
This increases the minimum height of the Scenery window to fit at least 1.5 rows of scenery items, instead of 1 row. This is done to ensure the eyedropper and scatter tools are visible with multiple rows of tabs as well.

Before:
<img width="634" height="224" alt="Imagination Megapark 2025-09-15 22-38-56" src="https://github.com/user-attachments/assets/dcce9fad-a8e1-4001-9552-dd1ff97c082c" />

After:
<img width="634" height="264" alt="Imagination Megapark 2025-09-15 22-38-46" src="https://github.com/user-attachments/assets/8e545aa7-8aef-4642-b78e-858bed2db1e8" />
2025-09-17 21:51:12 +00:00
Gymnasiast
aab21c4747 Rename validate_global_widx to VALIDATE_GLOBAL_WIDX 2025-09-17 23:50:28 +02:00
Gymnasiast
472e048f69 Make WindowView into strong enum 2025-09-17 23:49:17 +02:00
Gymnasiast
ea5fc03dd0 Turn WindowDetail into strong enum 2025-09-17 23:35:10 +02:00
Gymnasiast
a662c5ef8e Change WindowClass members to use lowerCamelCase 2025-09-17 23:18:52 +02:00
Gymnasiast
c94babb06e Rename g_window_list to gWindowList 2025-09-17 23:16:17 +02:00
Aaron van Geffen
51b4bbbce5 Allow shifting track designs underground
Since about a year ago, OpenRCT2 has allowed players to shift ride/track designs using modifier keys (#22669). This was, however, limited to heights above-ground. This PR changes this by omitting the 'Z placement assist' when ctrl/shift modifiers are used. This means the helpful 'nudge' to overground is now omitted if (and only if) these modifier keys are involved.

Below is an example of what placement now looks like (with clearance checks disabled for easier debugging):

https://github.com/user-attachments/assets/3b23bc1d-ab7b-43a2-ad40-216ab83952d2
2025-09-17 23:09:07 +02:00
Gymnasiast
3a803e13e2 Change window functions to use lowerCamelCase 2025-09-17 20:10:12 +02:00
Gymnasiast
d4a0bca091 Rename Window fields 2025-09-17 20:10:12 +02:00
Gymnasiast
a613b2604a Replace RCT_WINDOW_{RIGHT,BOTTOM} defines 2025-09-17 20:10:12 +02:00
Gymnasiast
f46fea3bff Rename rct_windownumber to WindowNumber 2025-09-17 20:10:12 +02:00