Ted John
7edf1e8b7f
Merge pull request #4936 from Broxzier/short
...
Because of a comment on a diff in #4878 asking for clearer and more consistent type usage. What this PR changes:
No unsigned long long found
(signed) long long -> sint64
unsigned int -> uint32
(signed) int -> sint32
(signed) long -> sint32
unsigned short -> uint16
(signed) short -> sint16
unsigned char -> uint8
No signed chars found
plain char is implementation-defined, so I left those in.
2017-01-14 23:41:47 +00:00
Ted John
0d51bdde3f
Fix broken code alignment
2017-01-14 23:40:46 +00:00
Ted John
fe389be7c9
Remove unused ride entry flags
2017-01-14 17:37:15 +00:00
Ted John
8f57e514fe
Name more ride entry flags
2017-01-14 17:36:47 +00:00
Ted John
769d86e7cc
Refactor vehicle_update_boat_location
2017-01-14 17:36:32 +00:00
Ted John
f4cea0e6c8
Name a couple of ride entry flags and format enum
2017-01-14 16:48:56 +00:00
Broxzier
b80b71cf81
Fixed typos and warnings after rebase
2017-01-14 14:31:06 +01:00
Broxzier
2bf1b4cd2f
Fox linux builds (hopefully)
2017-01-14 12:37:34 +01:00
Broxzier
a26eac91ef
Use typedef for diagnostic levels, small refactor
2017-01-14 12:37:33 +01:00
Broxzier
d857ebb2ad
Move type definitions before the first include
...
This way the last remaining uses of int could be replaced with sint32 as
well. Before this change there was a circular dependancy which made the
types unknown in diagnostic.h.
2017-01-14 12:37:32 +01:00
Broxzier
60603ae10a
Use types from common.h
2017-01-14 12:37:31 +01:00
Michał Janiszewski
d88635307f
Merge pull request #5062 from janisozaur/cmake-warnings
...
More warnings for CMake
2017-01-13 19:46:30 +01:00
Ted John
baed215984
Add helper: ride_has_ratings
...
#5066
2017-01-13 18:14:38 +00:00
Ted John
aed5c0aa60
Name flag: RIDE_TYPE_FLAG_26
2017-01-13 13:20:16 +00:00
Ted John
ae7048b2a7
Name flag: RIDE_TYPE_FLAG_30
2017-01-13 13:16:51 +00:00
Ted John
053f8a70bf
Name flag: RIDE_TYPE_FLAG_18
2017-01-13 13:13:24 +00:00
Ted John
cf0c489d40
Name flag: RIDE_TYPE_FLAG_13
2017-01-13 13:08:56 +00:00
Ted John
bdc5078003
Name flag: RIDE_TYPE_FLAG_6
2017-01-13 13:04:11 +00:00
Ted John
ef2ddbf462
Name flag: RIDE_TYPE_FLAG_20
2017-01-13 12:55:47 +00:00
Michał Janiszewski
09ecf0b73c
Fix possible null dereferences
2017-01-13 12:35:26 +01:00
Michał Janiszewski
0a36af19e4
Mark classes as final to help devirtualisation
2017-01-13 12:12:50 +01:00
Michał Janiszewski
411d1fff18
Make GCC suggest final, override keywords
2017-01-13 11:44:14 +01:00
Michał Janiszewski
33dcb1a506
Rename types to avoid shadowing
2017-01-13 10:57:00 +01:00
Michał Janiszewski
ecf77e3609
Remove redundant declarations
2017-01-13 10:02:17 +01:00
Michał Janiszewski
cf670deb10
Add -Wshadow to CMakeLists and fix offenders
2017-01-13 10:02:17 +01:00
Michael Steenbeek
2a435bfdae
Use constants for block brakes and some other elements
2017-01-13 09:49:29 +01:00
Ted John
7875fd1f3a
Ensure object list pointer is updated after realloc
...
Also update changelog for fix to #4944 .
2017-01-12 22:20:27 +00:00
Ted John
4090522901
Fix #4944 : Game crashes upon selecting objects in scenario editor
...
When the filter caused no results to be shown in the list, it would try to realloc for 0 bytes which returns NULL. The error shown in the console was a minor bug, the more serious issue was the the original memory was freed but the list pointer not updated. Instead just check for 0 items, dispose the list and return.
2017-01-12 22:12:21 +00:00
Ted John
d70cd3775e
Fix silent warnings
2017-01-12 18:40:49 +00:00
Ted John
ab4bb3101c
Use static inline
2017-01-12 18:29:29 +00:00
Ted John
1bf7a0ffdb
Fix Win32 warnings
2017-01-12 18:28:51 +00:00
Ted John
868bb54383
Fix remaining warnings
2017-01-12 18:20:22 +00:00
Ted John
b79af110c7
Fix more warnings
2017-01-12 18:02:28 +00:00
Ted John
50d0d69815
Fix name warnings for NetworkPacket
2017-01-12 17:45:48 +00:00
Ted John
18597bacb1
Fix more warnings
2017-01-12 17:36:05 +00:00
Ted John
ec07d61d7b
Fix name warnings for Network
2017-01-12 13:26:12 +00:00
Ted John
d2cf97d0a1
Fix name warnings for NetworkPlayer
2017-01-12 13:23:16 +00:00
Ted John
3a9b6f4bb0
Fix more warnings
2017-01-12 13:16:00 +00:00
Ted John
13a8eee1b4
More warning fixes, more warnings disabled
2017-01-12 13:12:53 +00:00
Ted John
ca9c3cc5ee
Fix more warnings, disable others
2017-01-12 13:00:12 +00:00
Ted John
bd732b99c7
Fix cast warnings
2017-01-12 12:41:47 +00:00
Ted John
e67d8b4122
Use inline instead of static for header C functions
2017-01-12 12:28:19 +00:00
Michał Janiszewski
171d973e55
Initialise fields of MemoryStream in header
...
This makes all the constructors use these defaulted values
2017-01-12 09:58:57 +01:00
Ferdinand Thiessen
afbe1dda0f
Fix 'No real prototype' warnings
2017-01-12 09:52:44 +01:00
LRFLEW
47c532d020
Don't zoom to cursor for keyboard or toolbar inputs ( #5028 )
2017-01-11 17:43:11 -06:00
Michael Steenbeek
e3cf32342b
Use constant for random colour
2017-01-11 23:00:28 +01:00
Gymnasiast
7767f506be
Fix balloon stall
2017-01-11 22:59:45 +01:00
Michael Steenbeek
92feea1612
Clean up metal supports
2017-01-11 20:23:47 +01:00
Ted John
e6dc4f179d
Fix Debug | Win32 (RCT2) builds for VS
2017-01-11 18:33:08 +00:00
Marijn van der Werf
b8bb3924a7
Fix cheat window colours ( #5041 )
2017-01-11 00:39:52 +01:00