With the changes in #22819, it seems reasonable to add a couple of
default searchable paths for Linux that are created by the
`game-data-packager` utility, available in Debian and its various
derivatives.
Signed-off-by: Mathias Gibbens <gibmat@debian.org>
* Put all of TitleSequenceManager into the same namespace
* Move RideConstructionState into the OpenRCT2 namespace
* Adopt existing namespaces into OpenRCT2 namespace
This adds `using namespace OpenRCT2` to compilation units where appropriate,
as a means to get the codebase to compile until these units have been placed
in a namespace of their own.
* Update Steam path detection for Linux
As Steam now uses Proton to install Windows version natively, update
paths so they get found automatically
* Use new Steam path detection on Linux only
This restores Steam path detection on macOS as it doesn't have Proton
simplify the Platform::GetInstallPath (linux) by removing unnecessary
vector, removing unused #ifdef path and using string_views where
appropriate. no vector was actually needed as the prefixes are fixed
(same as the SearchLocations) - using a plain array avoids an
unnecessary allocation (actually a couple as the old code was using
push_back without reserve).
how it was tested?
run the game, check it finds path OK - PASS
run in the debugger, actually loop through OK - PASS
https://github.com/OpenRCT2/OpenRCT2/pull/20502 changed how startup is
handled. This affected Android as well and changed AndroidClassLoader to
be initialized statically, but this turns out to be problematic due to
JVM not being fully initialized in our context by this time.
To fix this, move AndroidClassLoader initialization to JNI_OnLoad call,
where JVM is fully available.
Additionally, guard against multiple calls to JNI_OnLoad, an issue
present on Linux-like systems (including Android).
* Remove old interop macro
* Remove legacy string macro things
* Unbreak the posix/linux/unix builds
* Add String::IEquals and use it for case insensitive compare
* Add missing include for posix
* Replace _strnicmp with String::StartsWith
* Add LoByte and HiByte into Util.h, swap macros
* Fix android build
* Hopefully last of the string things
* Replace STUB directly with the warning
