Remove Platform::CoreInit

src/openrct2-cli/Cli.cpp

@@ -21,7 +21,6 @@ int main(int argc, const char** argv)
 {
     int32_t rc = EXIT_SUCCESS;
     int runGame = CommandLineRun(argv, argc);
-    Platform::CoreInit();
     if (runGame == EXITCODE_CONTINUE)
     {
         gOpenRCT2Headless = true;

src/openrct2-ui/Ui.cpp

@@ -44,7 +44,6 @@ int main(int argc, const char** argv)
     std::unique_ptr<IContext> context;
     int32_t rc = EXIT_SUCCESS;
     int runGame = CommandLineRun(argv, argc);
-    Platform::CoreInit();
     RegisterBitmapReader();
     if (runGame == EXITCODE_CONTINUE)
     {

src/openrct2/command_line/BenchSpriteSort.cpp

@@ -70,7 +70,6 @@ static void fixup_pointers(std::vector<RecordedPaintSession>& s)
 
 static std::vector<RecordedPaintSession> extract_paint_session(std::string_view parkFileName)
 {
-    Platform::CoreInit();
     gOpenRCT2Headless = true;
     auto context = OpenRCT2::CreateContext();
     std::vector<RecordedPaintSession> sessions;

src/openrct2/command_line/BenchUpdate.cpp

@@ -118,7 +118,6 @@ static int CommandLineForBenchSpriteSort(int argc, const char* const* argv)
     if (::benchmark::ReportUnrecognizedArguments(argc, &argv_for_benchmark[0]))
         return -1;
 
-    Platform::CoreInit();
     gOpenRCT2Headless = true;
 
     ::benchmark::RunSpecifiedBenchmarks();

src/openrct2/command_line/SimulateCommands.cpp

@@ -39,8 +39,6 @@ static exitcode_t HandleSimulate(CommandLineArgEnumerator* argEnumerator)
         return EXITCODE_FAIL;
     }
 
-    Platform::CoreInit();
-
     const char* inputPath = argv[0];
     uint32_t ticks = atol(argv[1]);
 

src/openrct2/interface/Screenshot.cpp

@@ -490,7 +490,6 @@ int32_t CommandLineForGfxbench(const char** argv, int32_t argc)
         return -1;
     }
 
-    Platform::CoreInit();
     int32_t iterationCount = 5;
     if (argc == 2)
     {
@@ -587,7 +586,6 @@ int32_t CommandLineForScreenshot(const char** argv, int32_t argc, ScreenshotOpti
     DrawPixelInfo dpi;
     try
     {
-        Platform::CoreInit();
         bool customLocation = false;
         bool centreMapX = false;
         bool centreMapY = false;

src/openrct2/platform/Platform.Common.cpp

@@ -37,10 +37,6 @@ static constexpr std::array _prohibitedCharacters = { '/' };
 
 namespace Platform
 {
-    void CoreInit()
-    {
-    }
-
     CurrencyType GetCurrencyValue(const char* currCode)
     {
         if (currCode == nullptr || strlen(currCode) < 3)

src/openrct2/platform/Platform.h

@@ -45,8 +45,6 @@ struct RealWorldTime;
 
 namespace Platform
 {
-    // Called very early in the program before parsing commandline arguments.
-    void CoreInit();
     std::string GetEnvironmentVariable(std::string_view name);
     std::string GetFolderPath(SPECIAL_FOLDER folder);
     std::string GetInstallPath();

test/tests/MultiLaunch.cpp

@@ -34,7 +34,6 @@ TEST(MultiLaunchTest, all)
     gOpenRCT2Headless = true;
     gOpenRCT2NoGraphics = true;
 
-    Platform::CoreInit();
     for (int i = 0; i < 3; i++)
     {
         auto context = CreateContext();

test/tests/Pathfinding.cpp

@@ -29,8 +29,6 @@ class PathfindingTestBase : public testing::Test
 public:
     static void SetUpTestCase()
     {
-        Platform::CoreInit();
-
         gOpenRCT2Headless = true;
         gOpenRCT2NoGraphics = true;
         _context = CreateContext();

test/tests/PlayTests.cpp

@@ -41,7 +41,6 @@ static std::unique_ptr<IContext> localStartGame(const std::string& parkPath)
 {
     gOpenRCT2Headless = true;
     gOpenRCT2NoGraphics = true;
-    Platform::CoreInit();
 
     auto context = CreateContext();
     if (!context->Initialise())

test/tests/ReplayTests.cpp

@@ -73,7 +73,6 @@ TEST_P(ReplayTests, RunReplay)
 {
     gOpenRCT2Headless = true;
     gOpenRCT2NoGraphics = true;
-    Platform::CoreInit();
 
     auto testData = GetParam();
     auto replayFile = testData.filePath;

test/tests/RideRatings.cpp

@@ -65,7 +65,6 @@ protected:
         gOpenRCT2Headless = true;
         gOpenRCT2NoGraphics = true;
 
-        Platform::CoreInit();
         auto context = CreateContext();
         bool initialised = context->Initialise();
         ASSERT_TRUE(initialised);

test/tests/S6ImportExportTests.cpp

@@ -187,8 +187,6 @@ TEST(S6ImportExportBasic, all)
     gOpenRCT2Headless = true;
     gOpenRCT2NoGraphics = true;
 
-    Platform::CoreInit();
-
     MemoryStream importBuffer;
     MemoryStream exportBuffer;
     MemoryStream snapshotStream;
@@ -233,8 +231,6 @@ TEST(S6ImportExportAdvanceTicks, all)
     gOpenRCT2Headless = true;
     gOpenRCT2NoGraphics = true;
 
-    Platform::CoreInit();
-
     MemoryStream importBuffer;
     MemoryStream exportBuffer;
     MemoryStream snapshotStream;