mirrors/OpenRCT2
1
0
Fork 0
mirror of https://github.com/OpenRCT2/OpenRCT2 synced 2026-01-04 13:42:55 +01:00
Code Issues Releases Wiki Activity

Fix buffer size handling for ride operations input

Browse Source 
Ensure a nicely terminated string
This commit is contained in:
Michael Steenbeek
2022-07-28 14:24:19 +02:00
committed by GitHub
parent 6852b184b6
commit e5d2e3001d
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/openrct2-ui/windows/Ride.cpp
View File

@@ -3303,8 +3303,8 @@ static void WindowRideOperatingLengthWindow(rct_window* w, rct_widgetindex widge
ft.Add<int16_t>(upperBound);
auto title = (widgetIndex == WIDX_MINIMUM_LENGTH) ? STR_MINIMUM_WAITING_TIME : STR_MAXIMUM_WAITING_TIME;
auto currentValue = (widgetIndex == WIDX_MINIMUM_LENGTH) ? ride->min_waiting_time : ride->max_waiting_time;
char buffer[5];
snprintf(buffer, 4, "%u", currentValue);
char buffer[5]{};
snprintf(buffer, std::size(buffer), "%u", currentValue);
WindowTextInputRawOpen(w, widgetIndex, title, STR_ENTER_VALUE, ft, buffer, 4);
}
@@ -3336,8 +3336,8 @@ static void WindowRideOperatingTweakTextInput(rct_window* w, const Ride& ride)
ft.Add<int16_t>(minValue);
ft.Add<int16_t>(maxValue);
char buffer[5];
snprintf(buffer, 4, "%u", ride.operation_option);
char buffer[5]{};
snprintf(buffer, std::size(buffer), "%u", ride.operation_option);
WindowTextInputRawOpen(w, WIDX_MODE_TWEAK, title, STR_ENTER_VALUE, ft, buffer, 4);
}