code set ride status, not yet fixed and tested

src/game.c

@@ -867,7 +867,7 @@ static uint32 game_do_command_table[58] = {
 	(uint32)game_load_or_quit,
 	0x006B3F0F,
 	0x006B49D9,
-	0x006B4EA6,
+	0,
 	0x006B52D4,
 	0, // 10
 	0x006B5559,
@@ -930,7 +930,7 @@ static GAME_COMMAND_POINTER* new_game_command_table[58] = {
 	game_command_emptysub,
 	game_command_emptysub,
 	game_command_emptysub,
-	game_command_emptysub,
+	game_command_set_ride_status,
 	game_command_emptysub,
 	game_command_set_ride_name, // 10
 	game_command_emptysub,

src/game.h

@@ -30,7 +30,7 @@ enum GAME_COMMAND {
 	GAME_COMMAND_LOAD_OR_QUIT, // 5
 	GAME_COMMAND_6,
 	GAME_COMMAND_7,
-	GAME_COMMAND_SET_RIDE_OPEN, // 8
+	GAME_COMMAND_SET_RIDE_STATUS, // 8
 	GAME_COMMAND_9,
 	GAME_COMMAND_SET_RIDE_NAME,
 	GAME_COMMAND_11,

src/localisation/string_ids.h

@@ -167,6 +167,10 @@ enum {
 	STR_OVERALL_VIEW = 996,
 	STR_VIEW_SELECTION = 997,
 
+	STR_REQUIRES_A_STATION_PLATFORM = 999,
+	STR_TRACK_IS_NOT_A_COMPLETE_CIRCUIT = 1000,
+	STR_TRACK_UNSUITABLE_FOR_TYPE_OF_TRAIN = 1001,
+
 	STR_CANT_OPEN = 1002,
 	STR_CANT_TEST = 1003,
 	STR_CANT_CLOSE = 1004,
@@ -438,6 +442,9 @@ enum {
 	STR_GUESTS = 1463,
 
 	STR_STAFF = 1468,
+	
+	STR_RIDE_MUST_START_AND_END_WITH_STATIONS = 1469,
+	STR_STATION_NOT_LONG_ENOUGH = 1470,
 
 	STR_SPEED = 1471,
 	STR_SPEED_TIP = 1472,
@@ -503,6 +510,8 @@ enum {
 	STR_RACE_WON_BY_GUEST = 1739,
 	STR_RACE_WON_BY = 1740,
 
+	STR_NOT_YET_CONSTRUCTED = 1741,
+
 	STR_MAX_PEOPLE_ON_RIDE = 1742,
 	STR_MAX_PEOPLE_ON_RIDE_TIP = 1743,
 

src/ride/ride.c

@@ -2689,6 +2689,418 @@ void ride_music_update_final()
 
 #pragma endregion
 
+/**
+ * 
+ *  rct2: 0x006B4CC1
+ */
+int ride_mode_check_valid_stations(rct_ride *ride)
+{
+	return RCT2_CALLPROC_X(0x006B4CC1, 0, 0, 0, 0, (int)ride, 0, 0) & 0x100;
+}
+
+/**
+ * 
+ *  rct2: 0x006B5872
+ */
+int ride_check_for_entrance_exit(int rideIndex)
+{
+	return RCT2_CALLPROC_X(0x006B4CC1, 0, 0, 0, rideIndex, 0, 0, 0) & 0x100;
+}
+
+/**
+ * 
+ *  rct2: 0x006B5952
+ */
+void sub_6B5952(int rideIndex)
+{
+	RCT2_CALLPROC_X(0x006B4CC1, 0, 0, 0, rideIndex, 0, 0, 0);
+}
+
+/**
+ * 
+ *  rct2: 0x006D3319
+ */
+int sub_6D3319(rct_map_element *mapElement)
+{
+	return RCT2_CALLPROC_X(0x006D3319, 0, 0, 0, 0, (int)mapElement, 0, 0) & 0x100;
+}
+
+/**
+ * 
+ *  rct2: 0x006CB149
+ */
+int sub_6CB149(rct_map_element *mapElement)
+{
+	return RCT2_CALLPROC_X(0x006CB149, 0, 0, 0, 0, (int)mapElement, 0, 0) & 0x100;
+}
+
+/**
+ * 
+ *  rct2: 0x006CB1D3
+ */
+int sub_6CB1D3(rct_map_element *mapElement)
+{
+	return RCT2_CALLPROC_X(0x006CB1D3, 0, 0, 0, 0, (int)mapElement, 0, 0) & 0x100;
+}
+
+/**
+ * 
+ *  rct2: 0x006CB25D
+ */
+int sub_6CB25D(rct_map_element *mapElement)
+{
+	return RCT2_CALLPROC_X(0x006CB25D, 0, 0, 0, 0, (int)mapElement, 0, 0) & 0x100;
+}
+
+/**
+ * 
+ *  rct2: 0x006CB2DA
+ */
+int sub_6CB2DA(rct_map_element *mapElement)
+{
+	return RCT2_CALLPROC_X(0x006CB2DA, 0, 0, 0, 0, (int)mapElement, 0, 0) & 0x100;
+}
+
+/**
+ * 
+ *  rct2: 0x006B4D26
+ */
+void sub_6B4D26(int rideIndex)
+{
+	RCT2_CALLPROC_X(0x006CB2DA, 0, 0, 0, rideIndex, 0, 0, 0);
+}
+
+/**
+ * 
+ *  rct2: 0x006DD84C
+ */
+int sub_6DD84C(rct_ride *ride)
+{
+	return RCT2_CALLPROC_X(0x006DD84C, 0, 0, 0, 0, (int)ride, 0, 0) & 0x100;
+}
+
+/**
+ * 
+ *  rct2: 0x006DF4D4
+ */
+int sub_6DF4D4(rct_ride *ride)
+{
+	return RCT2_CALLPROC_X(0x006DF4D4, 0, 0, 0, 0, (int)ride, 0, 0) & 0x100;
+}
+
+/**
+ * 
+ *  rct2: 0x006B51C0
+ */
+void loc_6B51C0(int rideIndex)
+{
+	int i, x, y, z;
+	rct_ride *ride;
+	rct_map_element *mapElement;
+	rct_window *w;
+
+	ride = GET_RIDE(rideIndex);
+
+	if (RCT2_GLOBAL(0x0141F568, uint8) != RCT2_GLOBAL(0x013CA740, uint8))
+		return;
+
+	w = window_get_main();
+	if (w == NULL)
+		return;
+
+	uint8 entranceOrExit = -1;
+	for (i = 0; i < 4; i++) {
+		if (ride->station_starts[i] == 0xFFFF)
+			continue;
+
+		if (ride->entrances[i] == 0xFFFF) {
+			entranceOrExit = 0;
+			break;
+		}
+
+		if (ride->exits[i] == 0xFFFF) {
+			entranceOrExit = 1;
+			break;
+		}
+	}
+
+	if (entranceOrExit == -1)
+		return;
+
+	if (ride->type != RIDE_TYPE_MAZE) {
+		x = (ride->station_starts[i] >> 8) * 32;
+		y = (ride->station_starts[i] & 0xFF) * 32;
+		z = ride->station_heights[i] * 8;
+		window_scroll_to_location(w, x, y, z);
+
+		mapElement = sub_6CAF80(rideIndex, &x, &y);
+		ride_find_track_gap(mapElement, &x, &y);
+		w = window_get_main();
+		rct_viewport *viewport = w->viewport;
+		ride_modify(mapElement, x, y);
+		
+		w = window_find_by_class(WC_RIDE_CONSTRUCTION);
+		if (w != NULL)
+			window_event_mouse_up_call(w, 29 + entranceOrExit);
+	}
+}
+
+/**
+ * 
+ *  rct2: 0x006B528A
+ */
+void loc_6B528A(rct_map_element *mapElement, int x, int y, int z)
+{
+	rct_ride *ride;
+	rct_window *w;
+
+	ride = GET_RIDE(mapElement->properties.track.ride_index);
+
+	if (RCT2_GLOBAL(0x0141F568, uint8) != RCT2_GLOBAL(0x013CA740, uint8))
+		return;
+
+	w = window_get_main();
+	if (w == NULL)
+		return;
+
+	window_scroll_to_location(w, x, y, z);
+	ride_modify(mapElement, x, y);
+}
+
+/**
+ * 
+ *  rct2: 0x006B4F6B
+ */
+rct_map_element *loc_6B4F6B(int rideIndex, int x, int y)
+{
+	rct_map_element *mapElement;
+
+	mapElement = map_get_first_element_at(x, y);
+	do {
+		if (map_element_get_type(mapElement) != MAP_ELEMENT_TYPE_TRACK)
+			continue;
+
+		uint32 unk = mapElement->properties.track.type << 4;
+		if (RCT2_GLOBAL(0x00F43484, uint32) & 0x80000) {
+			if (!(RCT2_ADDRESS(0x0099CA64, uint8)[unk] & 0x10))
+				continue;
+		} else {
+			if (!(RCT2_ADDRESS(0x0099BA64, uint8)[unk] & 0x10))
+				continue;
+		}
+
+		if (mapElement->properties.track.ride_index == rideIndex)
+			return mapElement;
+	} while (!map_element_is_last_for_tile(mapElement++));
+	
+	return NULL;
+}
+
+/**
+ * 
+ *  rct2: 0x006B4EEA
+ */
+int ride_is_valid_for_open(int rideIndex, int goingToBeOpen, int isApplying)
+{
+	int i, x, y, z, stationIndex;
+	rct_ride *ride;
+	rct_map_element *mapElement, *mapElement2;
+
+	ride = GET_RIDE(rideIndex);
+
+	window_close_by_class(WC_RIDE_CONSTRUCTION);
+	if (!ride_mode_check_valid_stations(ride))
+		return 0;
+
+	if (!ride_check_for_entrance_exit(rideIndex)) {
+		loc_6B51C0(rideIndex);
+		return 0;
+	}
+
+	if (goingToBeOpen && isApplying) {
+		sub_6B5952(rideIndex);
+		ride->lifecycle_flags |= RIDE_LIFECYCLE_EVER_BEEN_OPENED;
+	}
+
+	stationIndex = -1;
+	for (i = 0; i < 4; i++) {
+		if (ride->station_starts[i] != 0xFFFF) {
+			stationIndex = i;
+			break;
+		}
+	}
+
+	if (stationIndex == -1) {
+		RCT2_GLOBAL(RCT2_ADDRESS_GAME_COMMAND_ERROR_TEXT, uint16) = STR_NOT_YET_CONSTRUCTED;
+		if (RCT2_GLOBAL(RCT2_ADDRESS_RIDE_FLAGS + (ride->type * 8), uint32) & 0x8000)
+			return 0;
+
+		if (ride->type == RIDE_TYPE_MAZE)
+			return 0;
+
+		RCT2_GLOBAL(RCT2_ADDRESS_GAME_COMMAND_ERROR_TEXT, uint16) = STR_REQUIRES_A_STATION_PLATFORM;
+		return 0;
+	}
+
+	mapElement = loc_6B4F6B(rideIndex, ride->station_starts[i] >> 8, ride->station_starts[i] & 0xFF);
+	if (mapElement == NULL)
+		return 0;
+
+	z = ride->station_heights[i] * 8;
+	if (
+		ride->type == RIDE_TYPE_AIR_POWERED_VERTICAL_COASTER ||
+		ride->mode == RIDE_MODE_RACE ||
+		ride->mode == RIDE_MODE_CONTINUOUS_CIRCUIT ||
+		ride->mode == RIDE_MODE_CONTINUOUS_CIRCUIT_BLOCK_SECTIONED ||
+		ride->mode == RIDE_MODE_POWERED_LAUNCH_BLOCK_SECTIONED
+	) {
+		mapElement2 = ride_find_track_gap(mapElement, &x, &y);
+		RCT2_GLOBAL(RCT2_ADDRESS_GAME_COMMAND_ERROR_TEXT, uint32) = STR_TRACK_IS_NOT_A_COMPLETE_CIRCUIT;
+		if (mapElement2 != NULL) {
+			loc_6B528A(mapElement, x, y, z);
+			return 0;
+		}
+	}
+
+	if (
+		ride->mode == RIDE_MODE_CONTINUOUS_CIRCUIT_BLOCK_SECTIONED ||
+		ride->mode == RIDE_MODE_POWERED_LAUNCH_BLOCK_SECTIONED
+	) {
+		if (sub_6D3319(mapElement)) {
+			loc_6B528A(mapElement, x, y, z);
+			return 0;
+		}
+	}
+
+	if (ride->subtype != 255) {
+		rct_ride_type *rideType = GET_RIDE_ENTRY(ride->subtype);
+		if (rideType->var_008 & 2) {
+			RCT2_GLOBAL(RCT2_ADDRESS_GAME_COMMAND_ERROR_TEXT, uint32) = STR_TRACK_UNSUITABLE_FOR_TYPE_OF_TRAIN;
+			if (sub_6CB149(mapElement)) {
+				loc_6B528A(mapElement, x, y, z);
+				return 0;
+			}
+		}
+		if (rideType->var_008 & 4) {
+			RCT2_GLOBAL(RCT2_ADDRESS_GAME_COMMAND_ERROR_TEXT, uint32) = STR_TRACK_UNSUITABLE_FOR_TYPE_OF_TRAIN;
+			if (sub_6CB1D3(mapElement)) {
+				loc_6B528A(mapElement, x, y, z);
+				return 0;
+			}
+		}
+	}
+
+	if (ride->mode == RIDE_MODE_STATION_TO_STATION) {
+		mapElement2 = ride_find_track_gap(mapElement, &x, &y);
+		if (mapElement2 == NULL) {
+			RCT2_GLOBAL(RCT2_ADDRESS_GAME_COMMAND_ERROR_TEXT, uint32) = STR_RIDE_MUST_START_AND_END_WITH_STATIONS;
+			return 0;
+		}
+
+		RCT2_GLOBAL(RCT2_ADDRESS_GAME_COMMAND_ERROR_TEXT, uint32) = STR_STATION_NOT_LONG_ENOUGH;
+		if (sub_6CB25D(mapElement)) {
+			loc_6B528A(mapElement, x, y, z);
+			return 0;
+		}
+
+		RCT2_GLOBAL(RCT2_ADDRESS_GAME_COMMAND_ERROR_TEXT, uint32) = STR_RIDE_MUST_START_AND_END_WITH_STATIONS;
+		if (sub_6CB2DA(mapElement)) {
+			loc_6B528A(mapElement, x, y, z);
+			return 0;
+		}
+	}
+
+	if (isApplying)
+		sub_6B4D26(rideIndex);
+
+	if (
+		!(RCT2_GLOBAL(RCT2_ADDRESS_RIDE_FLAGS + (ride->type * 8), uint32) & 0x2000) &&
+		(ride->lifecycle_flags & RIDE_LIFECYCLE_ON_TRACK)
+	) {
+		if (sub_6DD84C(ride))
+			return 0;
+	}
+
+	if (
+		(RCT2_GLOBAL(0x0097D4F2 + (ride->type * 8), uint32) & 0x400) &&
+		(ride->lifecycle_flags & RIDE_LIFECYCLE_16) &&
+		(ride->lifecycle_flags & RIDE_LIFECYCLE_CABLE_LIFT)
+	) {
+		if (sub_6DF4D4(ride))
+			return 0;
+	}
+
+	return 1;
+}
+
+void ride_set_status(int rideIndex, int status)
+{
+	game_do_command(0, GAME_COMMAND_FLAG_APPLY, 0, rideIndex | (status << 8), GAME_COMMAND_SET_RIDE_STATUS, 0, 0);
+}
+
+/**
+ * 
+ *  rct2: 0x006B4EA6
+ */
+void game_command_set_ride_status(int *eax, int *ebx, int *ecx, int *edx, int *esi, int *edi, int *ebp)
+{
+	int rideIndex, targetStatus;
+	rct_ride *ride;
+
+	rideIndex = *edx & 0xFF;
+	targetStatus = (*edx >> 8) & 0xFF;
+
+	RCT2_GLOBAL(0x0141F56C, uint8) = 4;
+
+	ride = GET_RIDE(rideIndex);
+	RCT2_GLOBAL(0x00F43484, uint32) = RCT2_GLOBAL(RCT2_ADDRESS_RIDE_FLAGS + (ride->type * 8), uint32);
+
+	switch (targetStatus) {
+	case RIDE_STATUS_CLOSED:
+		if (*ebx & GAME_COMMAND_FLAG_APPLY) {
+			*ebx = 0;
+			return;
+		}
+
+		if (ride->status == targetStatus) {
+			if (!(ride->lifecycle_flags & RIDE_LIFECYCLE_BROKEN_DOWN)) {
+				ride->lifecycle_flags &= ~RIDE_LIFECYCLE_CRASHED;
+				ride_clear_for_construction(rideIndex);
+				ride_remove_peeps(rideIndex);
+			}
+		}
+
+		ride->status = RIDE_STATUS_CLOSED;
+		ride->lifecycle_flags &= ~RIDE_LIFECYCLE_PASS_STATION_NO_STOPPING;
+		ride->race_winner = 0xFFFF;
+		ride->var_14D |= (1 << 2) | (1 << 3);
+		window_invalidate_by_number(WC_RIDE, rideIndex);
+		*ebx = 0;
+		return;
+	case RIDE_STATUS_TESTING:
+	case RIDE_STATUS_OPEN:
+		if (ride->status == targetStatus) {
+			*ebx = 0;
+			return;
+		}
+
+		if (!ride_is_valid_for_open(rideIndex, targetStatus == RIDE_STATUS_OPEN, *ebx & GAME_COMMAND_FLAG_APPLY)) {
+			*ebx = MONEY32_UNDEFINED;
+			return;
+		}
+
+		if (*ebx & GAME_COMMAND_FLAG_APPLY) {
+			ride->race_winner = 0xFFFF;
+			ride->status = targetStatus;
+			ride_get_measurement(rideIndex, NULL);
+			ride->var_14D |= (1 << 2) | (1 << 3);
+			window_invalidate_by_number(WC_RIDE, rideIndex);
+		}
+		*ebx = 0;
+		return;
+	}
+}
+
 void ride_set_name(int rideIndex, const char *name)
 {
 	RCT2_GLOBAL(RCT2_ADDRESS_GAME_COMMAND_ERROR_TITLE, uint16) = STR_CANT_RENAME_RIDE_ATTRACTION;

src/ride/ride.h

@@ -293,7 +293,7 @@ enum {
 	RIDE_LIFECYCLE_MUSIC = 1 << 13,
 	RIDE_LIFECYCLE_INDESTRUCTIBLE = 1 << 14,
 	RIDE_LIFECYCLE_INDESTRUCTIBLE_TRACK = 1 << 15,
-
+	RIDE_LIFECYCLE_16 = 1 << 16,
 	RIDE_LIFECYCLE_CABLE_LIFT = 1 << 17,
 	RIDE_LIFECYCLE_18 = 1 << 18,
 	RIDE_LIFECYCLE_19 = 1 << 19
@@ -638,6 +638,8 @@ void ride_set_map_tooltip(rct_map_element *mapElement);
 int ride_music_params_update(sint16 x, sint16 y, sint16 z, uint8 rideIndex, uint16 sampleRate, uint32 position, uint8 *tuneId);
 void ride_music_update_final();
 
+void ride_set_status(int rideIndex, int status);
+void game_command_set_ride_status(int *eax, int *ebx, int *ecx, int *edx, int *esi, int *edi, int *ebp);
 void ride_set_name(int rideIndex, const char *name);
 void game_command_set_ride_name(int *eax, int *ebx, int *ecx, int *edx, int *esi, int *edi, int *ebp);
 

src/windows/ride.c

@@ -1834,7 +1834,7 @@ static void window_ride_main_dropdown()
 
 		RCT2_GLOBAL(0x013CE952 + 6, uint16) = ride->overall_view;
 		RCT2_GLOBAL(0x013CE952 + 8, uint32) = ride->name_arguments;
-		game_do_command(0, 1, 0, w->number | (status << 8), GAME_COMMAND_SET_RIDE_OPEN, 0, 0);
+		ride_set_status(w->number, status);
 		break;
 	}
 }

src/windows/ride_list.c

@@ -707,7 +707,7 @@ static void window_ride_list_close_all(rct_window *w)
 		RCT2_GLOBAL(0x013CE952 + 6, uint16) = w->scrolls[0].v_top;
 		RCT2_GLOBAL(0x013CE952 + 8, uint32) = w->scrolls[0].v_bottom;
 
-		game_do_command(0, 1, 0, i, GAME_COMMAND_SET_RIDE_OPEN, 0, 0);
+		ride_set_status(i, RIDE_STATUS_CLOSED);
 	}
 }
 
@@ -724,6 +724,6 @@ static void window_ride_list_open_all(rct_window *w)
 		RCT2_GLOBAL(0x013CE952 + 6, uint16) = w->scrolls[0].v_top;
 		RCT2_GLOBAL(0x013CE952 + 8, uint32) = w->scrolls[0].v_bottom;
 
-		game_do_command(0, 1, 0, (1 << 8) | i, GAME_COMMAND_SET_RIDE_OPEN, 0, 0);
+		ride_set_status(i, RIDE_STATUS_OPEN);
 	}
 }