mirrors/OpenRCT2
1
0
Fork 0
mirror of https://github.com/OpenRCT2/OpenRCT2 synced 2026-01-15 19:13:07 +01:00
Code Issues Releases Wiki Activity

Fix possible null dereference and resource leak

Browse Source
This commit is contained in:
Michał Janiszewski
2015-09-22 19:03:44 +02:00
parent 5ceafd66a3
commit cf7c827d0d
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/title.c
View File

@@ -579,11 +579,11 @@ static uint8 *title_script_load()
sprintf(path, "%s%c%s", gExePath, platform_get_path_separator(), filePath);
log_verbose("loading title script, %s", path);
file = SDL_RWFromFile(path, "r");
sint64 fileSize = SDL_RWsize(file);
if (file == NULL) {
log_error("unable to load title script");
return NULL;
}
sint64 fileSize = SDL_RWsize(file);
uint8 *binaryScript = (uint8*)malloc(1024 * 8);
if (binaryScript == NULL) {
@@ -624,7 +624,8 @@ static uint8 *title_script_load()
*scriptPtr++ = atoi(part1) & 0xFF;
} else {
log_error("unknown token, %s", token);
free(binaryScript);
SafeFree(binaryScript);
SDL_RWclose(file);
return NULL;
}
}