Refactor ride construction window (#17578)

src/openrct2/interface/Window.h

@@ -846,8 +846,6 @@ money32 place_provisional_track_piece(
     const CoordsXYZ& trackPos);
 
 extern RideConstructionState _rideConstructionState2;
-extern bool _stationConstructed;
-extern bool _deferClose;
 
 rct_window* window_get_listening();
 rct_windowclass window_get_classification(rct_window* window);

src/openrct2/ride/Ride.cpp

@@ -5879,6 +5879,11 @@ bool Ride::HasRecolourableShopItems() const
     return false;
 }
 
+bool Ride::HasStation() const
+{
+    return num_stations != 0;
+}
+
 std::vector<RideId> GetTracklessRides()
 {
     // Iterate map and build list of seen ride IDs

src/openrct2/ride/Ride.h

@@ -389,6 +389,7 @@ public:
     void SetLifecycleFlag(uint32_t flag, bool on);
 
     bool HasRecolourableShopItems() const;
+    bool HasStation() const;
 };
 
 #pragma pack(push, 1)
@@ -1074,7 +1075,6 @@ uint32_t ride_customers_in_last_5_minutes(const Ride* ride);
 
 Vehicle* ride_get_broken_vehicle(const Ride* ride);
 
-void window_ride_construction_do_station_check();
 void window_ride_construction_do_entrance_exit_check();
 
 money16 ride_get_price(const Ride* ride);

src/openrct2/ride/RideConstruction.cpp

@@ -54,9 +54,6 @@ money16 gTotalRideValueForMoney;
 
 money32 _currentTrackPrice;
 
-uint16_t _numCurrentPossibleRideConfigurations;
-uint16_t _numCurrentPossibleSpecialTrackPieces;
-
 uint32_t _currentTrackCurve;
 RideConstructionState _rideConstructionState;
 RideId _currentRideIndex;

src/openrct2/ride/RideConstruction.h

@@ -39,9 +39,6 @@ extern bool gGotoStartPlacementMode;
 
 extern money32 _currentTrackPrice;
 
-extern uint16_t _numCurrentPossibleRideConfigurations;
-extern uint16_t _numCurrentPossibleSpecialTrackPieces;
-
 extern uint32_t _currentTrackCurve;
 extern RideConstructionState _rideConstructionState;
 extern RideId _currentRideIndex;

src/openrct2/windows/_legacy.cpp

@@ -34,11 +34,6 @@ bool gDisableErrorWindowSound = false;
 
 RideConstructionState _rideConstructionState2;
 
-// This variable is updated separately from ride->num_stations because the latter
-// is unreliable if currently in station construction mode
-bool _stationConstructed;
-bool _deferClose;
-
 /**
  *
  *  rct2: 0x006CA162
@@ -410,23 +405,10 @@ void window_ride_construction_do_entrance_exit_check()
             {
                 window_event_mouse_up_call(w, WC_RIDE_CONSTRUCTION__WIDX_ENTRANCE);
             }
-            else
-            {
-                _deferClose = true;
-            }
         }
     }
 }
 
-void window_ride_construction_do_station_check()
-{
-    auto ride = get_ride(_currentRideIndex);
-    if (ride != nullptr)
-    {
-        _stationConstructed = ride->num_stations != 0;
-    }
-}
-
 void window_ride_construction_mouseup_demolish_next_piece(const CoordsXYZD& piecePos, int32_t type)
 {
     if (gGotoStartPlacementMode)