Fix compilation on Arch Linux with GCC 14 (#22031)

Fixes #22029

src/openrct2-ui/drawing/engines/opengl/OpenGLDrawingEngine.cpp

@@ -22,6 +22,7 @@
 #    include "TransparencyDepth.h"
 
 #    include <SDL.h>
+#    include <algorithm>
 #    include <cmath>
 #    include <openrct2-ui/interface/Window.h>
 #    include <openrct2/config/Config.h>

src/openrct2-ui/windows/ShortcutKeys.cpp

@@ -10,6 +10,7 @@
 #include "../input/ShortcutManager.h"
 #include "Window.h"
 
+#include <algorithm>
 #include <openrct2-ui/interface/Widget.h>
 #include <openrct2/drawing/Drawing.h>
 #include <openrct2/localisation/Formatter.h>

src/openrct2/core/Algorithm.hpp

@@ -9,6 +9,7 @@
 
 #pragma once
 
+#include <algorithm>
 #include <functional>
 
 template<class ForwardIt, class T, class Compare = std::less<>>

src/openrct2/core/Imaging.cpp

@@ -19,6 +19,7 @@
 #include "Memory.hpp"
 #include "String.hpp"
 
+#include <algorithm>
 #include <fstream>
 #include <png.h>
 #include <stdexcept>

src/openrct2/drawing/X8DrawingEngine.cpp

@@ -24,6 +24,7 @@
 #include "LightFX.h"
 #include "Weather.h"
 
+#include <algorithm>
 #include <cstring>
 
 using namespace OpenRCT2;

src/openrct2/entity/EntityTweener.cpp

@@ -14,6 +14,7 @@
 #include "EntityList.h"
 #include "EntityRegistry.h"
 
+#include <algorithm>
 #include <cmath>
 
 void EntityTweener::AddEntity(EntityBase* entity)

src/openrct2/object/Object.cpp

@@ -23,6 +23,7 @@
 #include "ObjectLimits.h"
 #include "ObjectRepository.h"
 
+#include <algorithm>
 #include <cstring>
 #include <stdexcept>
 

src/openrct2/object/ObjectTypes.cpp

@@ -12,6 +12,8 @@
 #include "../util/Util.h"
 #include "Object.h"
 
+#include <algorithm>
+
 constexpr std::array kAllObjectTypes = {
     ObjectType::Ride,
     ObjectType::SmallScenery,

src/openrct2/paint/Paint.h

@@ -73,7 +73,10 @@ struct PaintStringStruct
 struct PaintEntry
 {
 private:
-    std::array<uint8_t, std::max({ sizeof(PaintStruct), sizeof(AttachedPaintStruct), sizeof(PaintStringStruct) })> data;
+    // Avoid including expensive <algorithm> for std::max. Manually ensure we use the largest type.
+    static_assert(sizeof(PaintStruct) >= sizeof(AttachedPaintStruct));
+    static_assert(sizeof(PaintStruct) >= sizeof(PaintStringStruct));
+    std::array<uint8_t, sizeof(PaintStruct)> data;
 
 public:
     PaintStruct* AsBasic()

src/openrct2/util/Util.cpp

@@ -19,6 +19,7 @@
 #include "../scenes/title/TitleScene.h"
 #include "zlib.h"
 
+#include <algorithm>
 #include <cctype>
 #include <cmath>
 #include <ctime>