Move cstring out of common.h

src/openrct2/CmdlineSprite.cpp

@@ -16,6 +16,7 @@
 
 #pragma warning(disable : 4706) // assignment within conditional expression
 
+#include <cstring>
 #include <jansson.h>
 #include "CmdlineSprite.h"
 #include "drawing/Drawing.h"

src/openrct2/cmdline/CommandLine.cpp

@@ -14,6 +14,8 @@
  *****************************************************************************/
 #pragma endregion
 
+#include <cstring>
+
 #include "../core/Console.hpp"
 #include "../core/Math.hpp"
 #include "../core/String.hpp"

src/openrct2/common.h

@@ -30,7 +30,6 @@
 #include <cmath>
 #include <cstddef>
 #include <cstdint>
-#include <cstring>
 
 using sint8 = int8_t;
 using sint16 = int16_t;

src/openrct2/drawing/DrawingFast.cpp

@@ -16,6 +16,8 @@
 
 #pragma warning(disable : 4127) // conditional expression is constant
 
+#include <cstring>
+
 #include "Drawing.h"
 
 template<sint32 image_type, sint32 zoom_level>

src/openrct2/drawing/LightFX.cpp

@@ -18,6 +18,7 @@
 
 #include <algorithm>
 #include <cmath>
+#include <cstring>
 #include "../common.h"
 #include "../config/Config.h"
 #include "../Game.h"

src/openrct2/drawing/X8DrawingEngine.cpp

@@ -15,6 +15,7 @@
 #pragma endregion
 
 #include <algorithm>
+#include <cstring>
 #include "../config/Config.h"
 #include "../Context.h"
 #include "../ui/UiContext.h"

src/openrct2/localisation/Localisation.h

@@ -17,6 +17,8 @@
 #ifndef LOCALISATION_H
 #define LOCALISATION_H
 
+#include <cstring>
+
 #include "Currency.h"
 #include "Date.h"
 #include "FormatCodes.h"

src/openrct2/network/Http.cpp

@@ -14,8 +14,6 @@
  *****************************************************************************/
 #pragma endregion
 
-#include <thread>
-
 #include "http.h"
 
 #ifdef DISABLE_HTTP
@@ -25,6 +23,9 @@ void http_dispose() { }
 
 #else
 
+#include <cstring>
+#include <thread>
+
 #include "../core/Console.hpp"
 #include "../core/Math.hpp"
 #include "../Version.h"

src/openrct2/network/TcpSocket.cpp

@@ -18,6 +18,7 @@
 
 #include <cmath>
 #include <chrono>
+#include <cstring>
 #include <future>
 #include <string>
 #include <thread>

src/openrct2/object/ObjectList.cpp

@@ -14,6 +14,8 @@
  *****************************************************************************/
 #pragma endregion
 
+#include <cstring>
+
 #include "../core/Math.hpp"
 #include "../core/Util.hpp"
 #include "../Game.h"

src/openrct2/paint/tile_element/Surface.cpp

@@ -14,6 +14,8 @@
 *****************************************************************************/
 #pragma endregion
 
+#include <cstring>
+
 #include "../../OpenRCT2.h"
 #include "../../Cheats.h"
 #include "../../config/Config.h"

src/openrct2/platform/Linux.cpp

@@ -26,6 +26,7 @@
 
 #define OPENRCT2_MAX_COMMAND_LENGTH (2 * MAX_PATH)
 
+#include <cstring>
 #include <ctype.h>
 #include <dlfcn.h>
 #include <errno.h>

src/openrct2/platform/Posix.cpp

@@ -16,6 +16,7 @@
 
 #if defined(__unix__) || (defined(__APPLE__) && defined(__MACH__)) || defined(__FreeBSD__)
 
+#include <cstring>
 #include <ctype.h>
 #include <dirent.h>
 #include <errno.h>

src/openrct2/ride/thrill/RotoDrop.cpp

@@ -14,6 +14,8 @@
  *****************************************************************************/
 #pragma endregion
 
+#include <cstring>
+
 #include "../../common.h"
 #include "../../interface/Viewport.h"
 #include "../../paint/Paint.h"

src/openrct2/util/SawyerCoding.cpp

@@ -14,6 +14,8 @@
  *****************************************************************************/
 #pragma endregion
 
+#include <cstring>
+
 #include "../core/Math.hpp"
 #include "../platform/platform.h"
 #include "../scenario/Scenario.h"

src/openrct2/world/MapAnimation.cpp

@@ -14,6 +14,8 @@
  *****************************************************************************/
 #pragma endregion
 
+#include <cstring>
+
 #include "../Game.h"
 #include "../ride/Ride.h"
 #include "../ride/RideData.h"

src/openrct2/world/MapGen.cpp

@@ -16,6 +16,7 @@
 
 #include "../common.h"
 #include <cmath>
+#include <cstring>
 #include <vector>
 
 #include "../Context.h"

test/testpaint/Hook.cpp

@@ -16,6 +16,7 @@
 
 #include <cstdio>
 #include <cstdlib>
+#include <cstring>
 #include <openrct2/common.h>
 
 #ifndef NO_RCT2

test/testpaint/PaintIntercept.cpp

@@ -14,6 +14,7 @@
  *****************************************************************************/
 #pragma endregion
 
+#include <cstring>
 
 #include "Hook.h"
 #include "PaintIntercept.hpp"

test/testpaint/generate.cpp

@@ -16,6 +16,7 @@
 
 #include <algorithm>
 #include <cstdarg>
+#include <cstring>
 #include <string>
 #include <vector>
 

test/testpaint/main.cpp

@@ -17,6 +17,7 @@
 #include <algorithm>
 #include <cstdio>
 #include <cstdarg>
+#include <cstring>
 #include <string>
 #include <vector>