mirrors/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2025-12-10 07:22:34 +01:00
Code Issues Projects Releases Wiki Activity

daemon: fix print_cn command when 0 connections

Browse Source 
Deferencing the result of `std::max_element()` when `res.connections` has 0 elements leads to UB, and segfaults in practice.

Co-authored-by: iamamyth <user@example.com>
This commit is contained in:
jeffro256
2025-09-28 12:40:53 -05:00
parent b591866fcf
commit 4e9d199913
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/daemon/rpc_command_executor.cpp
View File

@@ -644,12 +644,9 @@ bool t_rpc_command_executor::print_connections() {
} }
} }
auto longest_host = *std::max_element(res.connections.begin(), res.connections.end(), int host_field_width = 15;
[](const auto &info1, const auto &info2) for (const auto &conn : res.connections)
{ host_field_width = std::max(host_field_width, 8 + (int) conn.address.length());
return info1.address.length() < info2.address.length();
});
int host_field_width = std::max(15, 8 + (int) longest_host.address.length());
tools::msg_writer() << std::setw(host_field_width) << std::left << "Remote Host" tools::msg_writer() << std::setw(host_field_width) << std::left << "Remote Host"
<< std::setw(8) << "Type" << std::setw(8) << "Type"