Replace linux-all with linux-assets (#381)

* Move linux package specific files to scripts/resources/pkg

* Replace linux-all with linux-assets

* Fix linux-x64 launchers issue

* Remove -e

.github/workflows/build_push.yml

@@ -81,11 +81,11 @@ jobs:
       fail-fast: false
       matrix:
         os:
+          - debian-all
+          - linux-assets
           - linux-x64
-          - linux-all
           - macOS-x64
           - macOS-arm64
-          - debian-all
           - windows-x64
           - windows-x86
 
@@ -133,11 +133,15 @@ jobs:
           path: release
       - uses: actions/download-artifact@v3
         with:
-          name: linux-x64
+          name: debian-all
           path: release
       - uses: actions/download-artifact@v3
         with:
-          name: linux-all
+          name: linux-assets
+          path: release
+      - uses: actions/download-artifact@v3
+        with:
+          name: linux-x64
           path: release
       - uses: actions/download-artifact@v3
         with:
@@ -147,10 +151,6 @@ jobs:
         with:
           name: macOS-arm64
           path: release
-      - uses: actions/download-artifact@v3
-        with:
-          name: debian-all
-          path: release
       - uses: actions/download-artifact@v3
         with:
           name: windows-x64

.github/workflows/publish.yml

@@ -81,15 +81,15 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [
-          linux-x64,
-          linux-all,
-          macOS-x64,
-          macOS-arm64,
-          debian-all,
-          windows-x64,
-          windows-x86,
-        ]
+        os:
+          - debian-all
+          - linux-assets
+          - linux-x64
+          - macOS-x64
+          - macOS-arm64
+          - windows-x64
+          - windows-x86
+
     name: Make ${{ matrix.os }} release
     needs: build
     runs-on: ubuntu-latest
@@ -135,11 +135,15 @@ jobs:
           path: release
       - uses: actions/download-artifact@v3
         with:
-          name: linux-x64
+          name: debian-all
           path: release
       - uses: actions/download-artifact@v3
         with:
-          name: linux-all
+          name: linux-assets
+          path: release
+      - uses: actions/download-artifact@v3
+        with:
+          name: linux-x64
           path: release
       - uses: actions/download-artifact@v3
         with:
@@ -149,10 +153,6 @@ jobs:
         with:
           name: macOS-arm64
           path: release
-      - uses: actions/download-artifact@v3
-        with:
-          name: debian-all
-          path: release
       - uses: actions/download-artifact@v3
         with:
           name: windows-x64

scripts/bundler.sh

@@ -42,9 +42,8 @@ main() {
       make_deb_package
       move_release_to_output_dir
       ;;
-    linux-all)
+    linux-assets)
       RELEASE="$RELEASE_NAME.tar.gz"
-      cp "$JAR" "$RELEASE_NAME/tachidesk-server.jar"
       copy_linux_package_assets_to "$RELEASE_NAME/"
       tar -I "gzip -9" -cvf "$RELEASE" "$RELEASE_NAME/"
       move_release_to_output_dir
@@ -151,11 +150,11 @@ copy_linux_package_assets_to() {
   local output_dir
   output_dir="$(readlink -e "$1" || exit 1)"
 
-  cp "scripts/resources/tachidesk-server-browser-launcher.sh" "$output_dir/"
-  cp "scripts/resources/tachidesk-server-debug-launcher.sh" "$output_dir/"
-  cp "scripts/resources/tachidesk-server-electron-launcher.sh" "$output_dir/"
-  cp "scripts/resources/tachidesk-server.desktop" "$output_dir/"
-  cp "scripts/resources/systemd"/* "$output_dir/"
+  cp "scripts/resources/pkg/tachidesk-server-browser-launcher.sh" "$output_dir/"
+  cp "scripts/resources/pkg/tachidesk-server-debug-launcher.sh" "$output_dir/"
+  cp "scripts/resources/pkg/tachidesk-server-electron-launcher.sh" "$output_dir/"
+  cp "scripts/resources/pkg/tachidesk-server.desktop" "$output_dir/"
+  cp "scripts/resources/pkg/systemd"/* "$output_dir/"
   cp "server/src/main/resources/icon/faviconlogo.png" \
     "$output_dir/tachidesk-server.png"
 }
@@ -274,7 +273,7 @@ make_windows_package() {
 # set -e is not recommended and unpredictable.
 # see https://stackoverflow.com/questions/64786/error-handling-in-bash
 # and http://mywiki.wooledge.org/BashFAO/105
-set -euo pipefail
+set -uo pipefail
 error() {
   local parent_lineno="$1"
   local message="$2"

scripts/resources/pkg/tachidesk-server-browser-launcher.sh

@@ -0,0 +1,3 @@
+#!/bin/sh
+
+exec /usr/bin/java -jar /usr/share/java/tachidesk-server/tachidesk-server.jar

scripts/resources/pkg/tachidesk-server-debug-launcher.sh

@@ -0,0 +1,5 @@
+#!/bin/sh
+
+exec /usr/bin/java \
+    -Dsuwayomi.tachidesk.config.server.debugLogsEnabled=true \
+    -jar /usr/share/java/tachidesk-server/tachidesk-server.jar

scripts/resources/pkg/tachidesk-server-electron-launcher.sh

@@ -0,0 +1,12 @@
+#!/bin/sh
+
+if [ ! -f /usr/bin/electron ]; then
+    echo "Electron executable was not found!
+In order to run this launcher, you need Electron installed."
+    exit 1
+fi
+
+exec /usr/bin/java \
+    -Dsuwayomi.tachidesk.config.server.webUIInterface=electron \
+    -Dsuwayomi.tachidesk.config.server.electronPath=/usr/bin/electron \
+    -jar /usr/share/java/tachidesk-server/tachidesk-server.jar

scripts/resources/tachidesk-server-browser-launcher.sh

@@ -1,2 +1,3 @@
 #!/bin/sh
-exec /usr/bin/java -jar /usr/share/java/tachidesk-server/tachidesk-server.jar
+
+exec ./jre/bin/java -jar ./tachidesk-server.jar

scripts/resources/tachidesk-server-debug-launcher.sh

@@ -1,4 +1,5 @@
 #!/bin/sh
-exec /usr/bin/java \
+
+exec ./jre/bin/java \
     -Dsuwayomi.tachidesk.config.server.debugLogsEnabled=true \
-    -jar /usr/share/java/tachidesk-server/tachidesk-server.jar
+    -jar ./tachidesk-server.jar

scripts/resources/tachidesk-server-electron-launcher.sh

@@ -1,12 +1,6 @@
 #!/bin/sh
 
-if [ ! -f /usr/bin/electron ]; then
-    echo "Electron executable was not found!
-In order to run this launcher, you need Electron installed."
-    exit 1
-fi
-
-exec /usr/bin/java \
+exec ./jre/bin/java \
     -Dsuwayomi.tachidesk.config.server.webUIInterface=electron \
-    -Dsuwayomi.tachidesk.config.server.electronPath=/usr/bin/electron \
-    -jar /usr/share/java/tachidesk-server/tachidesk-server.jar
+    -Dsuwayomi.tachidesk.config.server.electronPath=./electron/electron \
+    -jar ./tachidesk-server.jar