mirrors/Tachidesk
1
0
Fork 0
mirror of https://github.com/Suwayomi/Tachidesk.git synced 2025-12-10 06:42:07 +01:00
Code Issues Projects Releases Wiki Activity

Optionally allow basic auth fallback for chapter page endpoint (#1757)

Browse Source 
Requesting a chapter page while having a non basic auth mode (e.g. ui login) enabled caused the basic auth prompt.
However, this is only supposed to be happen for opds
This commit is contained in:
schroda
2025-11-01 19:31:01 +01:00
committed by GitHub
parent fb41ad38f6
commit 53c4659044
2 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
server/src/main/kotlin/suwayomi/tachidesk/manga/controller/MangaController.kt
View File

@@ -457,6 +457,7 @@ object MangaController {
pathParam<Int>("index"),
queryParam<Boolean?>("updateProgress"),
queryParam<String?>("format"),
queryParam<Boolean?>("opds"),
documentWith = {
withOperation {
summary("Get a chapter page")
@@ -465,8 +466,13 @@ object MangaController {
)
}
},
behaviorOf = { ctx, mangaId, chapterIndex, index, updateProgress, format ->
ctx.getAttribute(Attribute.TachideskUser).requireUserWithBasicFallback(ctx)
behaviorOf = { ctx, mangaId, chapterIndex, index, updateProgress, format, opds ->
if (opds == true) {
ctx.getAttribute(Attribute.TachideskUser).requireUserWithBasicFallback(ctx)
} else {
ctx.getAttribute(Attribute.TachideskUser).requireUser()
}
ctx.future {
future {
Page.getPageImage(

2
server/src/main/kotlin/suwayomi/tachidesk/opds/impl/OpdsEntryBuilder.kt
View File

@@ -365,7 +365,7 @@ object OpdsEntryBuilder {
if (chapter.pageCount > 0) {
val basePageHref =
"/api/v1/manga/${manga.id}/chapter/${chapter.sourceOrder}/page/{pageNumber}" +
"?updateProgress=${serverConfig.opdsEnablePageReadProgress.value}"
"?updateProgress=${serverConfig.opdsEnablePageReadProgress.value}&opds=true"
val title: String =
when {