mirrors/OpenTTD
1
0
Fork 0
mirror of https://github.com/OpenTTD/OpenTTD synced 2026-01-17 17:32:45 +01:00
Code Issues Releases Wiki Activity
29,782 Commits 23 Branches 224 Tags
c3bb512bd95ecb9f0a69cc67682e302df2f2ced3
Commit Graph

266 Commits

Author SHA1 Message Date
Peter Nelson
e98407973f Fix #12993: Replace known-bugs text with markdown version. 
This allows a little bit better formatting/display in game.

(No attempt to check if these are still valid known-bugs...)
 2024-10-22 00:34:16 +01:00
Jonathan G Rennison
6ca9ddcffa Codefix: [Win32] String handling in OTTDStringCompare, Win32StringContains 
Avoid truncation if CompareStringEx is missing
Fix handling of zero length inputs
 2024-10-21 17:34:30 +02:00
Jonathan G Rennison
d7a2efd623 Codefix: [Win32] Truncated stack trace symbols were not null-terminated 
SymGetSymFromAddr64/IMAGEHLP_SYMBOL64 do not null-terminate
symbols with lengths >= the name buffer size
 2024-10-21 17:34:03 +02:00
Peter Nelson
e2a796dbcd Codefix: Potential unterminated string returned from convert_to_fs. 
Converting from UTF-8 to UTF-16 could have resulted in a buffer overflow if the buffer size was exactly the length of the converted string.

Pass string_view/span to convert_from/to_fs instead, and ensure the buffer is terminated. This replaces passing a pointer to the buffer and the buffer size as separate parameters, allowing the compiler to pass both in one parameter.

Removes use of `lengthof()`.
 2024-07-10 20:57:02 +01:00
Peter Nelson
b37954722b Codefix: Don't copy path string to itself. 
When determining base paths on Windows the path is converted to UCS-16, and then copied into the same buffer.
 2024-07-10 20:57:02 +01:00
Peter Nelson
6120165433 Fix #12839: Truncated help text dialog on Windows. (#12844) 
Replace fixed-length buffer message conversion with std::string.
 2024-07-07 18:05:53 +01:00
glx22
b52f778f20 Codefix: [Win32] Use correct range for version in rc file 2024-06-26 23:02:27 +02:00
Peter Nelson
209b0320d5 Fix #12735: Default fonts should use default font size as-is. (#12814) 
Minimum readable font size should only apply to fallback and configured fonts.
 2024-06-26 12:45:39 +01:00
Peter Nelson
b56775f576 Codechange: Avoid making copies of intermediate layout runs. (#12796) 
The vector of runs is not used after it is passed to the ParagraphLayout class, so pass with std::move to avoid an unnecessary copy.
 2024-06-17 22:58:52 +01:00
Peter Nelson
f9f07e9001 Fix #12775: Text truncated incorrectly on Windows. (#12782) 
Caused by a -1 in the wrong place, which moved glyphs left one pixel.
 2024-06-14 16:32:31 +01:00
Peter Nelson
5cd81a980e Codechange: Store both left and right glyph positions in a run. 
This also allows the end of a run to be known without using an extra position entry.
 2024-06-09 09:57:20 +01:00
Peter Nelson
bbbf2b5282 Codechange: Return read-only span instead of vector from layout run functions. 2024-06-09 09:57:20 +01:00
Peter Nelson
48539992e8 Codechange: Use std::unordered_map for storing TrueTypeFontCache's GlyphEntry. 2024-05-30 20:16:28 +01:00
Peter Nelson
7b717fcccb Codechange: Replace AllocatorProc with SpriteAllocator class. 
This allows for state to be passed to or maintained by the allocator.
 2024-05-30 20:16:28 +01:00
Peter Nelson
3c42f701d7 Fix: Allow changing size of default OpenTTD font. (#12641) 
* Fix: Allow changing size of default OpenTTD font.

Size configuration for default font was ignored as a different code path to load the font was followed.

Resolved by removing this additional path and conditionally selecting the default font.
 2024-05-26 15:59:25 +01:00
Peter Nelson
3f5a354f37 Codechange: Use emplace with ICURun and UniscribeRun. (#12693) 2024-05-18 09:17:38 +01:00
Peter Nelson
c85481564f Codechange: Use reusable temporary buffer in Win32FontCache. (#12666) 
This avoids allocating and deleting a temporary buffer for every glyph that is rendered into a sprite.
 2024-05-17 08:50:59 +01:00
Peter Nelson
980dcaac6e Cleanup: Remove GetFontTable from FontCache. (#12677) 
This interface is no longer used, so does not need to be implemented.

Removes manual memory management with malloc/free.
 2024-05-14 21:13:26 +01:00
Peter Nelson
d78f39a9df Cleanup: Remove GetUnitsPerEM and units_per_em. (#12656) 
GetUnitsPerEM is never called.
 2024-05-11 14:50:34 +01:00
Peter Nelson
ec61951512 Cleanup: Remove Windows 9x font locale workaround. (#12644) 2024-05-09 07:03:02 +01:00
Peter Nelson
a1a01e21cf Change: Use std::make_unique instead of passing new() (#12539) 2024-04-20 11:20:49 +01:00
Peter Nelson
63ce81570c Remove: Custom opendir implementation for Windows no longer needed. 
std::filesystem::directory_iterator is now used instead.
 2024-04-18 01:41:14 +01:00
Peter Nelson
d7c547d0db Codechange: Use directory_iterator to list directories in file list windows. 
This replaces use of custom ttd_opendir. Files are listed separately using ScanPath as that handles downloaded content.
 2024-04-18 01:41:14 +01:00
Rubidium
eda10abc8c Codechange: pass command line arguments as std::span to openttd_main 2024-04-11 21:57:53 +02:00
rubidium42
442daf58da Codechange: replace lengthof with std::size in Windows specific code 2024-04-10 23:17:13 +02:00
Peter Nelson
3c94e81665 Codechange: Use ZOOM_LVL_MIN to refer to first zoom level. 
Many uses of ZOOM_LVL_NORMAL actually just want the first zoom level slot, so use ZOOM_LVL_MIN to make this clearer.
 2024-04-04 22:27:03 +01:00
Loïc Guilloux
11aa3694fa Fix: [Win32] Force font mapper to only use TrueType fonts (#12406) 2024-04-01 22:59:13 +02:00
Rubidium
caa7c44052 Cleanup: remove checks for old MSVC versions 2024-03-24 10:09:15 +01:00
Patric Stout
a3cfd23cf9 Codechange: rename byte to uint8_t (#12308) 2024-03-16 23:59:32 +01:00
frosch
b1718478c8 Codechange: Replace old non-standard attributes with C++17/20 standard attributes. 2024-02-02 22:29:28 +01:00
Loïc Guilloux
0e738dda88 Fix #11948: [Win32] Convert error messages to utf8 (#11951) 2024-02-02 16:30:23 +01:00
Peter Nelson
ae575a7a5b Codechange: Store text run positions in vector of points. 
This simplifies the interlaced vector of x/y positions.
 2024-01-19 00:08:31 +00:00
Peter Nelson
f7cc88f370 Codechange: Return vector references instead of pointer to first item. 2024-01-19 00:08:31 +00:00
Michael Lutz
36cf6b1d13 Feature: Scalable OpenTTD TrueType font made by Zephyris. 
This uses the normal variant for the small font, not the all-caps version.
 2024-01-14 22:50:56 +01:00
Michael Lutz
6e766a2e81 Change: Allow TrueType fonts to provide our private-use glyphs. 2024-01-14 22:50:56 +01:00
Loïc Guilloux
93ba6d6776 Fix: compilation without precompiled headers (#11770) 2024-01-14 13:27:03 +01:00
Loïc Guilloux
03df70ce8a Fix #11752: [Win32] Wrong multi-line text layout due to incorrect partial run handling (#11761) 2024-01-12 19:40:08 +01:00
Patric Stout
d3ee045c2d Codechange: refactor the Windows-only DllLoader in a cross-platform LibraryLoader (#11751) 2024-01-10 21:38:58 +00:00
Peter Nelson
b85ecf9ac2 Codechange: Replace pointer to Sprite array with reference to SpriteCollection. (#11580) 
Add `SpriteLoader::SpriteCollection` type which is an array of `SpriteLoad::Sprite`.

This removes the ambiguity of what `SpriteLoader::Sprite *` is pointing to,
and cleans up mismatches using both dereference -> and array access [] for the
same object.
 2023-12-20 20:38:21 +00:00
rubidium42
27082f9efa Codechange: pass std::string references to OpenBrowser 2023-11-29 02:02:30 +01:00
Peter Nelson
d4008850e3 Codechange: Ensure function opening { is on new line. 2023-11-09 20:15:38 +00:00
Michael Lutz
86e28e79fb Fix #11402: Make string filter locale-aware. 2023-11-03 22:34:01 +01:00
Rubidium
c6411168d8 Cleanup: missing spaces before continuation * in some comments 2023-11-01 22:56:11 +01:00
Rubidium
f16399f4c9 Codechange: replace x.size() > 0 with !x.empty() 2023-10-20 23:05:43 +02:00
Rubidium
c9276c2959 Codechange: replace x.size() == 0 with x.empty() 2023-10-20 23:05:43 +02:00
frosch
55da426d44 Codechange: All ParagraphLayoutFactory::AppendToBuffer assume that the buffer has at least some space. 
Assert on that.
 2023-09-19 22:49:59 +02:00
frosch
5733145c59 Cleanup: Remove unneeded parameters. 2023-09-19 22:49:59 +02:00
frosch
b6c8f301be Codechange: Silence warnings about intentionally unused parameters. 2023-09-19 22:49:59 +02:00
Patric Stout
37e2f99c09 Change: store crash logs in JSON format (#11232) 2023-09-14 20:13:27 +02:00
Patric Stout
ba67f39db6 Codechange: vendor the nlohmann-json library (#11290) 2023-09-13 16:11:34 +02:00