mirrors/OpenTTD
1
0
Fork 0
mirror of https://github.com/OpenTTD/OpenTTD synced 2026-01-16 00:42:45 +01:00
Code Issues Releases Wiki Activity
31,169 Commits 23 Branches 224 Tags
7805c1c189e7584ec526d5cd6ab6c666eeacdbfa
Commit Graph

358 Commits

Author SHA1 Message Date
Rubidium
7805c1c189 Codechange: use std::string_view for ini_key 2025-05-01 23:24:43 +02:00
Peter Nelson
394adb654e Codechange: Move GUI parts of badges to a separate file. (#14023) 2025-04-18 17:20:31 +01:00
Richard Wheeler
a93087ec5c Fix #13980: Allow diagonal selection for road convert (#13983) 
Fixes #13980
 2025-04-12 18:50:11 +01:00
Peter Nelson
732109e444 Codechange: Use EnumBitSet for RoadTypes. 2025-03-25 20:15:48 +00:00
Peter Nelson
819e097d6e Codechange: Use separate RoadTypes mask to list road or tram roadtypes. 
This simplifies logic reduces ambiguity.
 2025-03-25 20:15:48 +00:00
Peter Nelson
adb20f99ea Fix: Autoreplace rail/road list only listed buildable types. (#13887) 
Instead list all possible types which includes hidden types compatible with buildable types.
 2025-03-25 08:22:30 +00:00
Peter Nelson
a1bcfb836a Codechange: Remove leftover SetStringTips. 2025-03-04 08:23:28 +00:00
Peter Nelson
c7846f4629 Codechange: Move to GetWidgetString for road windows. 2025-03-03 21:20:14 +00:00
Peter Nelson
e2c1b9f03e Codechange: Use only raw strings in drop down lists. (#13667) 
Strings with parameters are now pre-formatted, avoiding global parameters.

Helper functions still allow StringID.
 2025-02-27 21:11:16 +00:00
Rubidium
b376e2655a Codechange: explicitly initialise member variables of Windows 2025-02-27 20:06:06 +01:00
Peter Nelson
8f14894024 Add: NewGRF Badges. 2025-02-16 22:24:25 +00:00
Rubidium
fd4adc55e3 Codechange: replace INVALID_X with XID::Invalid() for PoolIDs 2025-02-16 20:23:00 +01:00
Rubidium
c3d5e6d2a0 Codechange: Use EnumBitSet for DoCommandFlags 2025-02-14 00:28:57 +01:00
Peter Nelson
71dafdb21e Codechange: Use EnumBitSet for picker window invalidation flags. 2025-02-13 21:07:37 +00:00
Peter Nelson
75387b9e2b Codechange: Use EnumBitSet for StationFacility. 2025-02-13 18:03:13 +00:00
Peter Nelson
17f6da413d Codechange: Use EnumBitSet for RoadStopSpecFlags. 2025-02-04 18:52:08 +00:00
Peter Nelson
fb55ab0742 Codechange: Pass rect to DrawStationCoverageAreaText. (#13442) 
This moves the overflow behaviour to the callers, making it clearer why that is desired.
 2025-02-02 17:15:47 +00:00
Peter Nelson
40aeedeade Codechange: Use EnumBitSet for callback masks. 2025-01-31 17:08:24 +00:00
Peter Nelson
d30e8dd1c1 Codechange: Use EnumBitSet for WindowDefaultFlags. 2025-01-30 08:40:42 +00:00
Peter Nelson
5f0e4cd646 Codechange: Make RoadStopType an enum class. (#13340) 2025-01-19 21:43:17 +00:00
Peter Nelson
4397aa3909 Codechange: Make StationType an enum class. (#13339) 2025-01-19 20:53:08 +00:00
Rubidium
0aa9faf187 Codechange: use INVALID_TOWN instead of 0 to denote 'not applicable' 2025-01-19 16:54:42 +01:00
Rubidium
ef87acc1ff Codechange: make STR_NULL the default for all widget construction functions 2025-01-03 23:25:27 +01:00
Rubidium
b60101853c Codechange: add and use SetString over directly accessing widget_data 2025-01-03 12:14:55 +01:00
Rubidium
fb06ddafba Codechange: add and use SetSprite over directly accessing widget_data 2025-01-03 11:13:16 +01:00
Rubidium
f0a74fcabb Codechange: use SetToolTip instead of accessing tool_tip directly 2025-01-03 11:09:49 +01:00
Rubidium
7c2668d10f Codechange: replace SetDataTip(0x0, with SetTooltip( 2025-01-02 23:28:43 +01:00
Rubidium
d8d03212b8 Codechange: replace SetDataTip(SPR_ with SetSpriteTip(STR_ 2025-01-02 23:28:43 +01:00
Rubidium
4bf36e3fa6 Codechange: replace SetDataTip(STR_ with SetStringTip(STR_ 2025-01-02 23:28:43 +01:00
Peter Nelson
98e980c478 Codechange: WWT_TEXT, WWT_LABEL and WWT_EMPTY don't use colour. (#13218) 
Set colour for these widget types to INVALID_COLOUR to avoid giving the impression that the colour has a purpose.

A runtime exception is added to catch this the existing widget unit test.
 2025-01-01 15:38:19 +00:00
Peter Nelson
876d53282e Codechange: Use std::ranges::count(_if). 2024-11-24 10:36:03 +00:00
Peter Nelson
db1a1c5dd9 Change: Invalidate build toolbars when NewGRFs are changed. 
If NewGRFs are changed while a rail or road toolbar is open, the toolbar could refer to an invalid rail/road type. If so, close it.
 2024-10-31 09:10:01 +00:00
Peter Nelson
6d2b93d3b3 Codechange: Set up rail/road toolbar buttons during window's OnInit event. 
This ensures the buttons are configured without extra initialisation methods.
 2024-10-31 09:10:01 +00:00
Peter Nelson
0e3fdfb1b5 Codechange: Don't store pointer to RoadTypeInfo in road toolbar. 
Always look up via stored RoadType instead. This matches out the rail toolbar behaves, and avoids keeping an non-owned pointer lying around.
 2024-10-31 09:10:01 +00:00
Jonathan G Rennison
5c243ee8f0 Fix: Road stop availability callback (#12931) 2024-09-07 14:57:04 +01:00
Peter Nelson
4976a0140e Codefix: [UI] Incorrect initialisation order for rail/road toolbars. (#12843) 
The toolbar state was set after the widget tree is created, during which toolbar state is needed.
 2024-07-04 22:04:41 +01:00
Jonathan G Rennison
dc258ecbe0 Fix #12825: Crash when opening road toolbar in scenario editor 
Due to attempt to access missing road waypoint button
 2024-06-28 21:30:38 +02:00
Jonathan G Rennison
a43dacd988 Add: NewGRF custom road waypoint support 2024-06-24 22:12:08 +02:00
Jonathan G Rennison
9c84e5df3f Add: Road waypoint functionality 2024-06-24 22:12:08 +02:00
Peter Nelson
55314513ce Codechange: Pass NWidgetParts as span instead of begin/end pointers. (#12779) 2024-06-12 23:08:35 +01:00
Peter Nelson
4cf6d1dd79 Codechange: Pass WindowDesc by reference instead of pointer. (#12771) 
WindowDesc as passed to Windows is not optional so don't allow to it to be nullptr.
 2024-06-11 08:58:03 +01:00
Peter Nelson
b30fe0d7da Feature: Ctrl-click to toggle favourites in build-pickers. 
This allows ctrl-click on a type in a build-picker window to remember it
as a favourite. An new filter button to show only favourites makes it
simpler to use these types.

Favourite types are saved locally in favs.cfg, so are remembered between
games.
 2024-05-11 02:12:41 +01:00
Peter Nelson
fde3b35a24 Feature: New filter to show only used types in build-pickers. 
This filters the build-picker type lists to only show types that have
already been placed in the current game, making it simpler to get to
build matching features.
 2024-05-11 02:12:41 +01:00
Peter Nelson
cdc356e7bf Change: Unify station/waypoint/roadstop/object build-picker window code. 
These windows now share a common code base for choosing and display class and types.

An additional text filter is added to search types by name instead of just classes.
 2024-05-11 02:12:41 +01:00
Peter Nelson
d2c8b476b5 Codechange: Add functions to test if a station/roadstop class is a waypoint. 
This is now checked by class label instead of by index.
 2024-05-11 02:12:41 +01:00
Peter Nelson
cf94bd321d Codechange: Remove redundant SetMinimalSize of preview buttons. (#12622) 
These widgets are also sized in UpdateWidgetSize where the current bevel width is accounted for as well.
 2024-05-05 12:38:00 +01:00
Peter Nelson
33aedc43a5 Codechange: Shrink GUIList vectors less often, reserve before use. 
After sorting and filter lists for GUI, we often shirnk them to reduce size. However this has very little benefit:

1) The memory has already been allocated, so it doesn't prevent that memory being required.
2) It causes a new allocation and copy when the vector is shrunk, actually using more memory.
3) The list is in window state, so the lifetime is only while the window is open.
4) When a filter is clearer, the original size will be needed again, which will cause another allocation.

In fact it is beneficial to reserve to the known maximum in most cases, so do that instead.
 2024-04-27 19:25:34 +01:00
Peter Nelson
f44d8fa2e4 Codechange: Remove CDECL from filter functions. (#12578) 
These functions are not passed to qsort()...
 2024-04-25 22:13:23 +01:00
Peter Nelson
5bc9854be2 Codechange: Make sort list function lists safer. (#12574) 
GUIList has a pointer only to the start of each sort/filter func list, which has the potential for UB as it is unable to validate that the selected sort or filter type is in range.

Use a std::span instead and check if the selected type is in range before using it.
 2024-04-25 21:00:49 +01:00
Peter Nelson
77f27e0804 Change: Expose NewGRF classes and specs as spans and simplify iteration. 
This replaces some index-based loops with range loops.
 2024-04-09 21:46:59 +01:00