mirrors/OpenTTD
1
0
Fork 0
mirror of https://github.com/OpenTTD/OpenTTD synced 2026-01-23 04:04:09 +01:00
Code Issues Releases Wiki Activity
29,645 Commits 24 Branches 224 Tags
74910d3d144f5f36fea52d60607ae10ebbc15ca6
Commit Graph

1220 Commits

Author SHA1 Message Date
Peter Nelson
74910d3d14 Fix 908ee729: Inverted condition prevented actually writing data to files. (#12941) 2024-09-16 13:45:23 +00:00
Peter Nelson
908ee7292b Codechange: Replace all FILE * with FileHandle RAII class. (#12718) 
This removes the need to manually ensure all files are closed.
 2024-09-16 08:45:26 +01:00
Jonathan G Rennison
2a5a0b0990 Codechange: No longer allow saving of incorrect string container table fields 
See: 1250ce8f
 2024-09-14 15:32:48 +01:00
Jonathan G Rennison
c277ff121e Fix #12901: Savegame format of company allow lists 2024-09-14 15:32:48 +01:00
Peter Nelson
7f5a3eaf83 Codefix: Avoid type-casting function pointer with incorrect type. (#12929) 
Make `AutolengthProc` take `int` instead of `void *`, avoiding pointer parameters.
 2024-09-12 06:49:45 +01:00
Jonathan G Rennison
e477706bf5 Codechange: Add AssignBit function to assign the value of a single bit (#12934) 
* Codechange: Add AssignBit function to assign the value of a single bit

* Codechange: Replace various uses of SB with AssignBit

* Codechange: Replace various uses of SB with a constant with SetBit
 2024-09-10 08:36:58 -04:00
Jonathan G Rennison
39465d7f5c Codefix: Move saveload of road stop tile data (#12883) 
So that road stop tile data is also saved/loaded for road waypoints
 2024-08-13 19:49:53 +00:00
Kaiden Joy
7a698c7f1c Fix #12365: Company Window now displays proper inauguration year and period while in wallclock mode. 2024-08-13 20:13:51 +02:00
Peter Nelson
e69c065d6e Codechange: Use find_if to find waypoint StationSpec when converting old savegames. (#12865) 
This simplifies an indexed loop.
 2024-07-17 11:40:17 +01:00
Jonathan G Rennison
65c666cb57 Codechange: Remove unused size field from struct SaveLoad (#12859) 2024-07-14 14:30:35 -04:00
Peter Nelson
b4bcb330c7 Codechange: Replace GetSavegameFormat's compression output pointer with std::pair return. (#12850) 
This avoids using an unchecked pointer as an out-parameter.
 2024-07-09 18:57:47 +01:00
Peter Nelson
100dd7b6d1 Codechange: Use find_if to get default writeable saveload format. (#12849) 
* Codechange: Use find_if to get default writeable savegame format.

This removes the last of lastof, and so the lastof macro is removed.
 2024-07-09 17:07:40 +01:00
rubidium42
d3c7b1015c Codefix cff48c0f6: unused variable remained after refactor 2024-06-25 22:26:37 +02:00
Jonathan G Rennison
9c84e5df3f Add: Road waypoint functionality 2024-06-24 22:12:08 +02:00
Jonathan G Rennison
05b65703d3 Codechange: Increase size of StationType field in map array 
Move can station have wires bit to make room
 2024-06-24 22:12:08 +02:00
Peter Nelson
79c1492a73 Codechange: Use unique_ptr in MemoryDumper. (#12766) 
This replaces C-style manual memory management.
 2024-06-08 21:59:56 +01:00
Peter Nelson
d5671030b1 Codechange: Add NewGRFSpecsBase class to hold class/index information. 
Standardises how the class index is stored in the spec, instead of relying ot the Spec structs having the same members.

This allows retrieving class_index and index without searching or using pointer arithmetic.

'cls_id' is renamed to 'class_index' to make it clearer that it is an index rather than the multichar label of the class.
 2024-05-11 02:12:41 +01:00
merni-ns
55a7c59d13 Remove: NPF and pathfinder change settings 2024-05-10 10:38:44 +02:00
Peter Nelson
9008d793ab Change: Use per-company group numbers. (#12297) 
This is used by the default group name, replacing the use of group index.
 2024-05-07 19:01:28 +00:00
Rubidium
66354ab9eb Codechange: introduce allow list infrastructure for companies 2024-05-07 00:03:15 +02:00
Rubidium
1250ce8fdc Codechange: support storing std::string vectors/deques in the savegame 2024-05-07 00:03:15 +02:00
Peter Nelson
115ac2629b Cleanup: Remove TileMatrix that hasn't been used for 4+ years. (#12621) 
This 'nice' structure was left around from #8258 just in case it might be used again.

Spoiler alert: it hasn't.

This removes manual memory management. And otherwise unused and untested code.
 2024-05-04 09:41:58 +01:00
Jonathan G Rennison
11ec156b64 Codechange: Add a priority field to TimerGameTick::TPeriod 
Use this as the primary sort key for TimerGameTick::TPeriod,
to avoid container sort order changes on timer period saveload.
See: #12509
 2024-04-25 20:08:24 +02:00
Peter Nelson
26bb87ebf1 Codechange: Replace SaveLoad var length arrays with switch block and sizeof. (#12570) 
SlCalcConvMemLen(), SlCalcConfFileLen() and CalcOldVarLen() follow a pattern of looking up part of a value in an array.

These function returns the size of bytes of a variable type, but is not very clear. Replace with a switch block instead.

Removes lengthof, array indices, and magic numbers.
 2024-04-24 21:33:29 +01:00
Peter Nelson
1dc94d0670 Codechange: Construct string_view with first+last. (#12568) 
Avoids needing to calculate size when we already have last.
 2024-04-24 21:29:33 +01:00
Peter Nelson
959ced71bb Codechange: Add constants for original input/output cargo counts. (#12548) 
This replaces some magic 3s and 2s.
 2024-04-20 20:50:48 +01:00
Rubidium
fc7f184dbd Codechange: move knowledge about 'packed' orders to the saveload code 2024-04-20 11:58:07 +02:00
Peter Nelson
ed2db80990 Codechange: Use map.emplace() instead of map.insert(std::pair). 
This avoids a copy of the pair into the map.
 2024-04-20 10:25:20 +01:00
Peter Nelson
57d7359b1a Codechange: Remove old group liveries savegame conversion. (#12537) 
Conversion to set default group livery is in the wrong place (not in `AfterLoadGame()`), however it is not necessary any more as `AfterLoadGame()` always calls the function `UpdateCompanyLiveries()` which will do the same thing.
 2024-04-20 10:25:04 +01:00
Peter Nelson
699c7e4c9d Fix 3de8853e29: Industries accept/produce no cargo for pre-SLV_78 saves. (#12508) 
Industry accepted/produced was trimmed too early for original and pre-SLV_78 saves, as cargo type was not stored per slot so all slots look invalid to the trim function.
 2024-04-20 10:24:35 +01:00
Peter Nelson
a28ab8cac2 Codechange: Replace C-style casts to size_t with static_cast. (#12455) 
* Codechange: Replace C-style casts to size_t with static_cast.

This touches only simple value-type casts.

* Codechange: Replace static_cast<size_t>(-1) with SIZE_MAX

Co-authored-by: Rubidium <rubidium@openttd.org>
 2024-04-19 20:34:36 +01:00
Peter Nelson
3b75d8bbf8 Fix: Use modern comparisons instead of memcmp in cache check. 
This uses C++20 default operator<=> to provide comparisons of some objects.

This works properly with caches that containers.
 2024-04-18 22:13:55 +01:00
Peter Nelson
45886e50b2 Codechange: Unify where rail station tile flags are set. (#12531) 
This avoids repeating the logic in three places.
 2024-04-18 18:54:10 +01:00
Rubidium
4f2412a272 Codechange: range based for loops instead of C-style for loops 2024-04-11 07:05:04 +02:00
Rubidium
df8eeb1b10 Codechange: use C++ algorithms to determine the SaveLoadFormat 2024-04-09 23:36:39 +02:00
Rubidium
4e6d4fcf32 Codechange: replace for loops with endof with range-based for loops 2024-04-08 07:00:55 +02:00
Peter Nelson
9854553e10 Codechange: ZOOM_LVL_SHIFT/BASE are not actually ZOOM_LVLs. 
Rename to ZOOM_BASE_SHIFT and ZOOM_BASE respectively, and derive from ZOOM_LVL instead of numeric value.
 2024-04-04 22:27:03 +01:00
Peter Nelson
3de8853e29 Codechange: Store accepted and produced cargo in vector instead of array. 
Most industries do not use the full 16 slots, so this can save a little memory and iteration time.
 2024-04-01 21:35:20 +01:00
Peter Nelson
00e0021e3a Codechange: Don't assume accepted/produced slot exists. 2024-04-01 21:35:20 +01:00
Peter Nelson
295508fc53 Codechange: Avoid lengthof() on std::array. 2024-04-01 21:35:20 +01:00
Peter Nelson
f79ec7955a Codechange: Explicitly reset old industry data before loading games. 2024-04-01 21:35:20 +01:00
Peter Nelson
bd2a92331b Codechange: Use inline and std::array for old industry structures. 
This avoids separate declaration/definition, and less C-style arrays.
 2024-04-01 21:35:20 +01:00
merni-ns
6f36f3d714 Fix #11055: Make saveload failure error messages consistent with others (#12247) 
The save/load error messages were combined using string parameters, rather than using the built-in functionality of error dialogs.
 2024-04-01 17:57:03 +01:00
Peter Nelson
df2ee7b06c Cleanup: Remove old SaveLoad workarounds for MS VS 2017. (#12355) 2024-03-23 00:12:35 +00:00
Patric Stout
a3cfd23cf9 Codechange: rename byte to uint8_t (#12308) 2024-03-16 23:59:32 +01:00
Patric Stout
3e625b5b1a Add: track savegame size to report with survey (#12304) 2024-03-16 08:58:56 +01:00
Rubidium
27eadc13ec Codechange: rename TILE_ADD(XY) to TileAdd(XY) 2024-03-10 15:50:24 +01:00
Rubidium
bab5a8a787 Codechange: use std::source_location over __FILE__ and __LINE__ for Backup 2024-03-10 10:14:20 +01:00
Tyler Trahan
32b0fb9f6e Fix #12010: Use economy timer for vehicle stats minimum age, not calendar (#12142) 2024-03-09 09:38:52 -05:00
Loïc Guilloux
845b894fd8 Remove: [Script] random_deviation from setting description table (#12221) 2024-03-05 12:41:04 +01:00