From 821a496495d4d59346390a92bd65dea52fd6a102 Mon Sep 17 00:00:00 2001 From: Peter Nelson Date: Fri, 21 Nov 2025 17:26:12 +0000 Subject: [PATCH] Codefix 0455627d16: Don't make temporary copies of order when converting old orders. (#14808) --- src/saveload/order_sl.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/saveload/order_sl.cpp b/src/saveload/order_sl.cpp index 2e1ecaea76..da1c0983e1 100644 --- a/src/saveload/order_sl.cpp +++ b/src/saveload/order_sl.cpp @@ -191,7 +191,7 @@ struct ORDRChunkHandler : ChunkHandler { /* Update all the next pointer. The orders were built like this: * While the order is valid, the previous order will get its next pointer set */ - for (uint32_t num = 1; OldOrderSaveLoadItem item : _old_order_saveload_pool) { + for (uint32_t num = 1; const OldOrderSaveLoadItem &item : _old_order_saveload_pool) { if (!item.order.IsType(OT_NOTHING) && num > 1) { OldOrderSaveLoadItem *prev = GetOldOrder(num - 1); if (prev != nullptr) prev->next = num;