1
0
mirror of https://github.com/OpenRCT2/OpenRCT2 synced 2026-01-24 15:24:30 +01:00
Commit Graph

78 Commits

Author SHA1 Message Date
Michael Steenbeek
fcf507e051 Spin off shop item stuff to separate files 2018-05-14 19:21:43 +02:00
Ted John
d7e93cec27 Prevent use of Context during ~Context 2018-05-13 00:43:56 +01:00
Hielke Morsink
afac7f6557 Make more global functions part of rct_peep 2018-05-05 11:42:43 +01:00
duncanspumpkin
fcb66b7449 Start refactoring pathfinding to use tileCoords 2018-05-05 11:42:34 +01:00
duncanspumpkin
ddbcae801e Use correct remove function 2018-05-05 11:42:27 +01:00
duncanspumpkin
5d7da79702 Label next_var_29. Add accessor functions.
Removed unused flag (1<<4). Not set in any save. Possibly left over from RCT1
2018-05-05 11:42:15 +01:00
duncanspumpkin
a94fb2fa2e Use Invalidate 2018-05-05 11:35:54 +01:00
duncanspumpkin
8d37502c7a Further use of SetState 2018-05-05 11:08:17 +01:00
duncanspumpkin
cbefe633d0 Further fixing 2018-05-05 11:06:26 +01:00
duncanspumpkin
f245d049f1 Further fixing 2018-05-05 11:04:49 +01:00
Michael Steenbeek
5f9d40be7a Replace tile_element_get_type() with struct method 2018-05-02 19:27:04 +02:00
Michael Steenbeek
b725916808 Use TitleCase 2018-05-02 13:27:53 +02:00
Michael Steenbeek
ef433df26a Clean up tile element usage, introduce struct methods 2018-05-02 11:58:12 +02:00
Hielke Morsink
30063984e6 Delete unused function arguments or mark them so (#7426)
This aims to make future refactoring easier. The arguments are removed where possible, but kept and marked with C++17's [[maybe_unused]] where they could not be removed (e.g. when they are used as a callback, rather than called directly).

I've skipped the rides/<category>/* and peep/* source files, because the rides source files are mostly generated and have a ton of unused variables, and the peep source files are being refactored.
I've also skipped most of window/* source files, because most of the functions are used as callbacks and will be bulk-renamed at some point.
2018-04-20 13:56:37 +02:00
duncanspumpkin
e4e514c743 Fix travis errors. Revert mistaken rename.
Use enum where known

Remove unused cases
2018-04-11 18:16:23 +01:00
duncanspumpkin
765500adfa Label offsets and functions
Actually save before commiting

Label more peep vars.

Remove unread var

Further refactoring

Fix mistake in map element type
2018-04-11 18:16:09 +01:00
duncanspumpkin
a24c2672fd Label all peep ride sub states
Add additional notes to function.

Perform exorcism on code base

Use vector for carArray
2018-04-11 18:15:47 +01:00
duncanspumpkin
fc14f6e635 Refactor peep update ride sub state 0 2018-04-11 18:13:17 +01:00
Hielke Morsink
dc673a64d8 Give context the ownership of repositories and the object manager (#7340)
This makes them no longer a singleton, which fixes annoying behaviour when launching multiple contexts in one game session.
2018-04-10 13:19:23 +01:00
Michael Steenbeek
cfb5a6b39d Correct spelling of 'sujonkwa' 2018-03-29 13:00:01 +02:00
zaxcav
9d3e1fbedf Fix #7176 pending breakdown interfering with mechanic heading to inspection (#7201)
* Fix pending breakdown interfering with mechanic heading to inspection

* Rename peep_fixing sub states per suggestions.

Reset ride->mechanic_status to UNDEFINED in sub-state finish fix/inspect (previously sub_state_13).

* Increment network version. Fix tabs/spaces
2018-03-20 21:55:30 +00:00
Michał Janiszewski
cd065d4f41 Reduce includes in common header 2018-03-20 00:27:58 +01:00
Michał Janiszewski
9b0fe5f09e Don't use registers struct where not strictly required
The only advantage of `struct registers` is the union hierarchy. If this
is not being actively exploited, it is detrimental to use this struct.
2018-03-14 22:11:30 +01:00
Ted John
42490b64fc Show entrance / exit fix messages as verbose only
This is because some title sequences have parks which need fixes and they end up showing on stdout every game launch.
2018-03-10 15:18:25 +01:00
Hielke Morsink
4bfeaf0c72 Fix #6870 Crash when loading groena lund
This crash only occurs when the option "no test crashes" was enable. With this commit the sprite index will be checked before the vehicle gets checked.
2018-03-10 06:50:45 +00:00
Michael Steenbeek
88af2d3954 Rename sub_6CA2DF() to window_ride_construction_update_state() 2018-03-09 09:17:24 +01:00
Michael Steenbeek
1fa2fa8f80 Refactor ride->entrances and ride->exits 2018-03-07 19:10:50 +01:00
ZehMatt
e3708c0593 Split special direction to new parameter. 2018-03-05 00:17:34 +01:00
ZehMatt
bdc1cf8adc Refactor GAME_COMMAND_MAZE_SET_TRACK to game action. 2018-03-05 00:17:34 +01:00
Aaron van Geffen
ba1d269227 Move all Virtual Floor code from Map to its own file. 2018-03-04 19:28:56 +01:00
ZehMatt
fdf7adecd9 Fix #7002: Always invalidate virtual floor regardless of selection. 2018-03-04 19:28:56 +01:00
Michael Steenbeek
f4ac2b4d5b Replace LocationXYZD16 2018-02-16 16:16:49 +01:00
Michael Steenbeek
bde913ee16 Rename SmallCoords and BigCoords 2018-02-15 22:26:50 +01:00
Michael Steenbeek
a2260929dd Replace rct_xy_element with BigCoordsXYE 2018-02-15 22:26:50 +01:00
Michael Steenbeek
d481cca2ed Remove some redundant casts and fix rct_sprite::AsDuck() 2018-02-15 13:04:25 +01:00
jensj12
02474353e3 Reduce duplicate code
Fix two cases of duplicated code
2018-02-13 00:11:29 +01:00
Ted John
7e01dcdaaf Remove legacy object list 2018-02-12 12:48:41 +00:00
Ted John
4d8fe051e8 Remove most usages of object_entry_groups 2018-02-12 12:48:41 +00:00
jensj12
06e52f2d6f Fix #7137: Water, gentle and transport rides can only have 1 vehicle... (#7159)
.../train
2018-02-10 19:22:28 +00:00
Ted John
97032f7044 Merge pull request #7062 from rwjuk/fix7052
Fix #7052: Infinite loops occur in track circuit iteration
2018-02-06 11:42:19 +00:00
Gymnasiast
cc4f7e144a Remove most usages of 'new Intent' 2018-02-05 23:23:26 +01:00
Gymnasiast
e3c0f6606d Clean up Intent.{cpp,h}
This gets rid of the C transfer functions, add licence and does some alignment fixes
2018-02-05 23:23:26 +01:00
duncanspumpkin
ac2ad02491 Update name of chairlift flag 2018-01-30 12:53:50 +00:00
duncanspumpkin
eb5f8485fa Name further entry flags 2018-01-30 12:53:50 +00:00
duncanspumpkin
5401e69b50 Name vehicle animation offsets 2018-01-30 12:53:50 +00:00
duncanspumpkin
93d1b7a233 Label vehicle sound2 flags 2018-01-30 12:53:50 +00:00
duncanspumpkin
4551f9c04e Label flags 2018-01-30 12:53:50 +00:00
duncanspumpkin
96f664abb9 Fix Water Ride spinning on slope bug. Name flags. Refactor
There was a bug in the spinning water ride code that would mean that it would never trigger the stopping of spinning when going up a lift. This mistake was made during implementation of the function.
2018-01-30 12:53:50 +00:00
duncanspumpkin
f9d6203200 Refactor vehicle spinning.
Fix bug in R8_SPIN and LR_SPIN that would cause vehicles to spin in wrong direction on certain track elements.
Name parameters
Name flag for additional vehicle spinning sprites
Add comments to code to make function easier to understand.
2018-01-30 12:53:50 +00:00
pss9205
d6bf08e407 Fix #7030: Ride reliability underflows 2018-01-28 12:51:45 +01:00