mirrors/OpenRCT2
1
0
Fork 0
mirror of https://github.com/OpenRCT2/OpenRCT2 synced 2026-01-30 02:05:13 +01:00
Code Issues Releases Wiki Activity
21,992 Commits 8 Branches 59 Tags
1b4875e528f221cf75cdfecc0434396edf5c22a0
Commit Graph

663 Commits

Author SHA1 Message Date
Michał Janiszewski
1b4875e528 Extract math-related functions from common.h to Math.hpp 
Saves wide inclusion of <stdexcept> header, which pulls in <string>
 2021-10-09 21:43:06 +02:00
Soham Roy
4d27417fd2 Fix #11354: Coding style causes undefined behaviour 
An underscore followed by a capital letter used as a prefix might cause
undefined behaviour
 2021-10-05 13:58:50 +02:00
Hielke Morsink
1d62a902e7 Make scenery_small_entry_has_flag a member function (#15509) 2021-10-01 16:50:05 -03:00
Michael Steenbeek
317e562845 Merge pull request #15495 from ZehMatt/refactor/xyz-access 
Use GetLocation in more places
 2021-10-01 14:02:34 +02:00
Hielke Morsink
94144bcd89 Remove some dead code 
Reported by clang
clang-analyzer-deadcode.DeadStores
 2021-09-30 10:40:32 +02:00
Duncan
8c6f10797b Prevent wasting paint time on unviewable entities 2021-09-29 19:20:43 +02:00
ζeh Matt
eb2de0222b Use GetLocation in more places 2021-09-28 03:16:04 +03:00
ζeh Matt
4ea8902587 Refactor arg passing to sprite_paint_setup 2021-09-27 22:48:06 +03:00
ζeh Matt
cecf4ac202 Use CoordsXY for sprite_paint_setup 
Co-authored-by: Ted John <ted@brambles.org>
 2021-09-27 22:47:36 +03:00
Hielke Morsink
53c22c9b4b Check for nullptr explicitly (#15458) 2021-09-24 20:05:50 +02:00
Duncan
c05068e8d1 Replace sprite_left,t,r,b with SpriteRect (#15408) 
* Replace sprite_left,t,r,b with SpriteRect

This is required for the NSF. I had to add a silly constructor to rct_sprite for now. Will eventually be removed one day...

* Fix compilation and memory leak

* Add some UB to prevent some other UB

* Make review change
 2021-09-18 19:07:35 +01:00
Hielke Morsink
4b4b3333d6 Remove unnecessary else blocks 2021-09-16 18:31:12 +02:00
Gymnasiast
c567ca09db Fix stray changes 2021-09-12 17:52:01 +02:00
IntelOrca
4f319d6ed4 Prepare footpath handling for surfaces and railings 2021-09-12 17:52:01 +02:00
ζeh Matt
b733e97bfa Remove numerics from common.h and use it as needed 2021-09-11 20:21:08 +03:00
ζeh Matt
2e8d40b5e3 Fix out of bounds regression from #15391 2021-09-10 22:34:18 +03:00
ζeh Matt
0b12076f2f Fix #15390: Revert quadrant distribution change and cleanup 2021-09-10 17:35:44 +03:00
ζeh Matt
6a7fe6a5e2 Fix #15376: Extend the X axis on rotation 0 to cover corners 
Also make the code branchless
 2021-09-08 23:13:19 +03:00
Michael Steenbeek
f9f027e219 Name word_F3F038 (#15373) 
Co-authored-by: IntelOrca <ted@brambles.org>
 2021-09-08 15:40:35 +02:00
ζeh Matt
876329da87 Fix hash bucketing of paint entries 2021-09-07 18:04:09 +03:00
Gymnasiast
4cc717ccdb Rework path surface and railings descriptor handling 2021-09-05 19:09:09 +02:00
Gymnasiast
2282f24404 Rename path surface and railings descriptors 2021-09-05 19:09:09 +02:00
ζeh Matt
01c808c601 Remove unused argument of wooden_(a|b)_supports_paint_setup 2021-08-26 20:54:06 +03:00
ζeh Matt
55add9883f Implement DirectionFlipXAxis 2021-08-24 22:57:13 +02:00
Duncan
201a94f7e6 Add overloads to take CoordsXYZ (#15253) 2021-08-24 16:26:52 +01:00
ζeh Matt
f49559daa5 Fix #15259: Large scenery not rendering correctly 2021-08-22 22:05:05 +02:00
Michael Steenbeek
7b3258b17e Merge pull request #15248 from ZehMatt/refactor/paint-hierarchy 
Refactor PaintAddImageAsParent overloads
 2021-08-21 21:33:06 +02:00
ZehMatt
0e08286d88 Apply review comments 2021-08-21 14:07:27 +03:00
Hielke Morsink
15d3a4a9da Update more include guards (#15254) 2021-08-21 12:55:28 +02:00
Hielke Morsink
dd2467d805 Update include guards 
- Update from C-style to pragma once
- Add missing include guard to ui.h
 2021-08-21 09:43:26 +02:00
Michael Steenbeek
a38ae68f09 Remove Paint.cpp assertions 
Before the refactor, the assertion read like this:
```
assert(static_cast<uint16_t>(bound_box_length_x) == static_cast<int16_t>(bound_box_length_x));
```
which meant that bound_box_length_x = 0 was valid. The refactor (likely accidentally) changed this, which causes assertions to get hit within 2 seconds after opening on my machine.

According to Duncan, the asserts are no longer necessary at all, so remove them altogether.
 2021-08-20 23:27:58 +02:00
ZehMatt
3d90257dde Simplify more argument passing to PaintAddImageAsParent 2021-08-20 23:34:44 +03:00
ZehMatt
7764bb910f Use CoordsXYZ instead of anonymous struct in unk_supports_desc 2021-08-20 23:34:44 +03:00
ZehMatt
efa9af4610 Simplify passing args on PaintAddImageAsParent where possible 2021-08-20 23:34:44 +03:00
ZehMatt
7feea62ab3 Remove overload of PaintAddImageAsParent with bbox offset 2021-08-20 23:34:44 +03:00
ZehMatt
6c233ac802 Remove first overload of PaintAddImageAsParent 2021-08-20 23:34:44 +03:00
ζeh Matt
4bc5f70581 Minor refactor work around the painting (#15226) 
* Remove unused variables and drop packing of paint structs

* Move PAINT_QUADRANT_FLAGS out of the header

* Rename enum and variable to SortFlags

* Rename variable and document the sorting

* Apply review
 2021-08-17 09:32:58 +01:00
Duncan
940cab87d3 Map size refactors from NSF (#15112) 
* Support large map sizes

* Fix top spin painting

* Fix crooked house

* Increase bb size

* Decrease limit back

* Clang format

* Remove asserts and apply review comments

* Fix rebase mistake

Co-authored-by: Ted John <ted@brambles.org>
 2021-08-16 20:51:16 +01:00
Michael Steenbeek
8f5ec43486 Pass derived tile element classes to functions (#15206) 2021-08-11 23:26:46 +02:00
ZehMatt
575a24956d Feature #15164: Highlight selected Tile Inspector element 2021-08-10 16:49:41 +03:00
Ted John
70d9c1438e Change most things and formatting to money64 2021-08-01 15:14:42 +02:00
Duncan
e9eb1b8304 Banner Refactor from NSF (#14788) 
* Banner refactor

* Fix mistake in fix_duplicated_banners

* Reduce limit back

* Fix export

* Free banner on delete

* Increment network version

* Fix potential banner pointer crashes

Co-authored-by: Ted John <ted@brambles.org>
 2021-07-27 10:25:58 +01:00
duncanspumpkin
ae6657dcdc Close #14903. Use map_is_edge 2021-07-19 12:17:22 +02:00
ζeh Matt
751c419594 Minor cleanups (#14954) 
* Fix uninitialized variables in InputManager

* Use constexpr for const values

* Add break statements instead of implicit fallthrough

* Default initialize variables in Cheats window

* Default initialize variables in News window

* Default initialize window event pointers
 2021-06-26 01:43:05 -03:00
Duncan
35ba734669 Minor paint refactor (#14905) 
Names a few unknown flags
 2021-06-22 07:36:17 +01:00
Jamie Quigley
4f6d0a00fd Refactor RIDE_STATUS to use strong enum (#14840) 
* Refactor RIDE_STATUS to use strong enum

* Change platform-specific code to match RIDE_STATUS refactor

* Re-added check for valid RideStatus value

* Fixed errors in "g2" build target

* Use EnumValue instead of static_cast<uint8_t>

* Revert rct{1,2}.h to use uint8_t.

* Fix formatting

* Reverted from constexpr variable to additional enum variant

* Fix formatting
 2021-06-10 07:09:58 +01:00
Michael Steenbeek
8e01bd46ce Remove LocationXY(Z)16 (#14834) 2021-06-07 17:44:38 +02:00
Jamie Quigley
1d84bdca88 Refactor PATH_BIT_DRAW_TYPE_LIGHTS to use strong enum (#14837) 
* Refactor PATH_BIT_DRAW_TYPE to use strong enum

* Rename PathBitDrawType members to be singular

* Remove whitespace and add trailing comma
 2021-06-07 13:40:27 +01:00
Matt
e289e21503 Address code review 2021-06-05 17:24:37 +03:00
Matt
a35d221afa Remove unnecessary construction of CoordsXYZ in Supports.cpp 2021-06-05 17:16:07 +03:00