From fe5a47c6b15c9d20596d987ca65a4fd5cead97bc Mon Sep 17 00:00:00 2001 From: mix <167040362+mixiate@users.noreply.github.com> Date: Wed, 16 Jul 2025 12:07:39 +0100 Subject: [PATCH] Fix new ride window authors (#24773) --- distribution/changelog.txt | 1 + src/openrct2-ui/windows/NewRide.cpp | 10 ++++------ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/distribution/changelog.txt b/distribution/changelog.txt index 2bd26509c5..75a671cc83 100644 --- a/distribution/changelog.txt +++ b/distribution/changelog.txt @@ -4,6 +4,7 @@ - Feature: [#24702] [Plugin] Add bindings for missing cheats (forcedParkRating, ignoreRidePrice, makeAllDestructible). - Change: [#24730] Security guards now only walk slowly in crowded areas. - Fix: [#24598] Cannot load .park files that use official legacy footpaths by accident. +- Fix: [#24773] The new ride window debug authors does not show the correct authors for non legacy ride objects. 0.4.24 (2025-07-05) ------------------------------------------------------------------------ diff --git a/src/openrct2-ui/windows/NewRide.cpp b/src/openrct2-ui/windows/NewRide.cpp index b12f1222d1..7e48b97303 100644 --- a/src/openrct2-ui/windows/NewRide.cpp +++ b/src/openrct2-ui/windows/NewRide.cpp @@ -980,14 +980,12 @@ namespace OpenRCT2::Ui::Windows } // Draw object author(s) if debugging tools are active - if (Config::Get().general.DebuggingTools) + if (Config::Get().general.DebuggingTools && !rideObj->GetAuthors().empty()) { - auto repoItem = ObjectRepositoryFindObjectByEntry(&(rideObj->GetObjectEntry())); - - StringId authorStringId = repoItem->Authors.size() > 1 ? STR_AUTHORS_STRING : STR_AUTHOR_STRING; + const auto& authors = rideObj->GetAuthors(); std::string authorsString; - for (auto& author : repoItem->Authors) + for (auto& author : authors) { if (!authorsString.empty()) authorsString.append(", "); @@ -996,7 +994,7 @@ namespace OpenRCT2::Ui::Windows } ft = Formatter(); - ft.Add(authorStringId); + ft.Add(authors.size() > 1 ? STR_AUTHORS_STRING : STR_AUTHOR_STRING); ft.Add(authorsString.c_str()); DrawTextEllipsised(