From f9649795a0c1457fc6d1e6515ed93b200743c706 Mon Sep 17 00:00:00 2001 From: zzril <84280965+zzril@users.noreply.github.com> Date: Fri, 13 Jan 2023 23:40:19 +0100 Subject: [PATCH] Fix #19112: Search filter in does not properly clear Co-authored-by: Josh Trzebiatowski --- contributors.md | 1 + distribution/changelog.txt | 1 + src/openrct2-ui/windows/EditorObjectSelection.cpp | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/contributors.md b/contributors.md index 73b218c67b..d7db53a3c6 100644 --- a/contributors.md +++ b/contributors.md @@ -207,6 +207,7 @@ The following people are not part of the development team, but have been contrib * Conrad Cash (HouseholdVTuber) * Michael Bickerton (mdbckrtn) * Nehemiah Negussie (nehemiah-negussie) +* (zzril) ## Toolchain diff --git a/distribution/changelog.txt b/distribution/changelog.txt index bace31c8c7..af6f261997 100644 --- a/distribution/changelog.txt +++ b/distribution/changelog.txt @@ -16,6 +16,7 @@ - Fix: [#18911] Mini Golf station does not draw correctly from all angles. - Fix: [#18971] New Game does not prompt for save before quitting. - Fix: [#19026] Park loan is clamped to a 32-bit integer. +- Fix: [#19112] Clearing the last character in the Object Selection filter does not properly reset it. - Fix: [#19114] [Plugin] GameActionResult does not comply to API specification. 0.4.3 (2022-12-14) diff --git a/src/openrct2-ui/windows/EditorObjectSelection.cpp b/src/openrct2-ui/windows/EditorObjectSelection.cpp index fe7d43c2c3..6112c71483 100644 --- a/src/openrct2-ui/windows/EditorObjectSelection.cpp +++ b/src/openrct2-ui/windows/EditorObjectSelection.cpp @@ -793,7 +793,7 @@ public: void OnTextInput(WidgetIndex widgetIndex, std::string_view text) override { - if (widgetIndex != WIDX_FILTER_TEXT_BOX || text.empty()) + if (widgetIndex != WIDX_FILTER_TEXT_BOX) return; std::string tempText = text.data();