From f6d78375b566fbebd6a61d4d84341ef26dc8b24b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=CE=B6eh=20Matt?= <5415177+ZehMatt@users.noreply.github.com> Date: Mon, 21 Apr 2025 03:41:56 +0300 Subject: [PATCH] Remove pointless overloads of iequals, implicitly converts to views --- src/openrct2/core/String.cpp | 10 ---------- src/openrct2/core/String.hpp | 2 -- 2 files changed, 12 deletions(-) diff --git a/src/openrct2/core/String.cpp b/src/openrct2/core/String.cpp index 1da45aa6d4..c57a787298 100644 --- a/src/openrct2/core/String.cpp +++ b/src/openrct2/core/String.cpp @@ -172,11 +172,6 @@ namespace OpenRCT2::String return equalsImpl(a, b, false); } - bool equals(const u8string& a, const u8string& b) - { - return equalsImpl(a, b, false); - } - bool equals(const utf8* a, const utf8* b, bool ignoreCase) { if (a == b) @@ -197,11 +192,6 @@ namespace OpenRCT2::String return equalsImpl(a, b, true); } - bool iequals(const u8string& a, const u8string& b) - { - return equalsImpl(a, b, true); - } - bool iequals(const utf8* a, const utf8* b) { if (a == b) diff --git a/src/openrct2/core/String.hpp b/src/openrct2/core/String.hpp index 113f4977d7..a196b6a587 100644 --- a/src/openrct2/core/String.hpp +++ b/src/openrct2/core/String.hpp @@ -52,10 +52,8 @@ namespace OpenRCT2::String int32_t compare(const utf8* a, const utf8* b, bool ignoreCase = false); bool equals(u8string_view a, u8string_view b); - bool equals(const u8string& a, const u8string& b); bool equals(const utf8* a, const utf8* b, bool ignoreCase = false); bool iequals(u8string_view a, u8string_view b); - bool iequals(const u8string& a, const u8string& b); bool iequals(const utf8* a, const utf8* b); bool startsWith(std::string_view str, std::string_view match, bool ignoreCase = false);