From dabeb036a636a93d60a00255532384a1ac3d572c Mon Sep 17 00:00:00 2001 From: Matt Date: Sun, 21 Feb 2021 19:13:58 +0200 Subject: [PATCH] Apply review suggestions --- src/openrct2/world/TileInspector.cpp | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/openrct2/world/TileInspector.cpp b/src/openrct2/world/TileInspector.cpp index c9dd180a03..1aa8423a71 100644 --- a/src/openrct2/world/TileInspector.cpp +++ b/src/openrct2/world/TileInspector.cpp @@ -75,7 +75,7 @@ namespace OpenRCT2::TileInspector static rct_window* GetTileInspectorWithPos(const CoordsXY& loc) { - // Update the tile inspector's list for everyone who has the tile selected + // Return the tile inspector window for everyone who has the tile selected auto* window = window_find_by_class(WC_TILE_INSPECTOR); if (window != nullptr && loc == windowTileInspectorTile.ToCoordsXY()) { @@ -150,13 +150,14 @@ namespace OpenRCT2::TileInspector static int32_t numLargeScenerySequences(const CoordsXY& loc, const LargeSceneryElement* const largeScenery) { const rct_scenery_entry* const largeEntry = largeScenery->GetEntry(); - const auto* const tiles = largeEntry->large_scenery.tiles; const auto direction = largeScenery->GetDirection(); - - const auto rotatedFirstTile = CoordsXYZ{ CoordsXY{ tiles[largeScenery->GetSequenceIndex()].x_offset, - tiles[largeScenery->GetSequenceIndex()].y_offset } - .Rotate(direction), - tiles[largeScenery->GetSequenceIndex()].z_offset }; + const auto sequenceIndex = largeScenery->GetSequenceIndex(); + const auto* tiles = largeEntry->large_scenery.tiles; + const auto& tile = tiles[sequenceIndex]; + const auto rotatedFirstTile = CoordsXYZ{ + CoordsXY{ tile.x_offset, tile.y_offset }.Rotate(direction), + tile.z_offset, + }; const auto firstTile = CoordsXYZ{ loc, largeScenery->GetBaseZ() } - rotatedFirstTile; auto numFoundElements = 0;