From d2e1857733f800980ce90bc66262c04816d8b7f0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Janiszewski?= Date: Sun, 4 Dec 2016 12:03:32 +0100 Subject: [PATCH] Fix #4793: Inventions list broken This reverts commit 3f767ed8ff2 and replaces it with exact check that doesn't trigger array-bounds GCC warning with `-O3` --- src/windows/editor_inventions_list.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/windows/editor_inventions_list.c b/src/windows/editor_inventions_list.c index ea26f61e36..bcc95604fd 100644 --- a/src/windows/editor_inventions_list.c +++ b/src/windows/editor_inventions_list.c @@ -419,9 +419,7 @@ static void move_research_item(rct_research_item *beforeItem) rct_window *w; rct_research_item *researchItem, draggedItem; - // We only really care about `_editorInventionsListDraggedItem == beforeItem - 1`, - // but this would cause a GCC warning due to -Warray-bounds - if (_editorInventionsListDraggedItem < beforeItem) + if (_editorInventionsListDraggedItem + 1 == beforeItem) return; // Back up the dragged item