mirrors/OpenRCT2
1
0
Fork 0
mirror of https://github.com/OpenRCT2/OpenRCT2 synced 2026-01-24 23:34:37 +01:00
Code Issues Releases Wiki Activity

Refactor to use string_view more properly

Browse Source
This commit is contained in:
skdltmxn
2021-01-07 01:22:22 +09:00
parent 017f7ef9e4
commit c093a50f3f
60 changed files with 197 additions and 203 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/openrct2/scripting/Plugin.cpp
View File

@@ -28,7 +28,7 @@ Plugin::Plugin(duk_context* context, const std::string& path)
{
}
void Plugin::SetCode(const std::string_view& code)
void Plugin::SetCode(std::string_view code)
{
_code = code;
}
@@ -146,7 +146,7 @@ PluginMetadata Plugin::GetMetadata(const DukValue& dukMetadata)
return metadata;
}
PluginType Plugin::ParsePluginType(const std::string_view& type)
PluginType Plugin::ParsePluginType(std::string_view type)
{
if (type == "local")
return PluginType::Local;
@@ -155,10 +155,10 @@ PluginType Plugin::ParsePluginType(const std::string_view& type)
throw std::invalid_argument("Unknown plugin type.");
}
void Plugin::CheckForLicence(const DukValue& dukLicence, const std::string_view& pluginName)
void Plugin::CheckForLicence(const DukValue& dukLicence, std::string_view pluginName)
{
if (dukLicence.type() != DukValue::Type::STRING || dukLicence.as_string().empty())
log_error("Plugin %s does not specify a licence", pluginName.data());
log_error("Plugin %s does not specify a licence", std::string(pluginName).data());
}
#endif