mirrors/OpenRCT2
1
0
Fork 0
mirror of https://github.com/OpenRCT2/OpenRCT2 synced 2026-01-29 17:54:50 +01:00
Code Issues Releases Wiki Activity

Refactor to use string_view more properly

Browse Source
This commit is contained in:
skdltmxn
2021-01-07 01:22:22 +09:00
parent 017f7ef9e4
commit c093a50f3f
60 changed files with 197 additions and 203 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/openrct2/core/ZipAndroid.cpp
View File

@@ -22,7 +22,7 @@ private:
jobject _zip;
public:
ZipArchive(const std::string_view& path, ZIP_ACCESS access)
ZipArchive(std::string_view path, ZIP_ACCESS access)
{
// retrieve the JNI environment.
JNIEnv* env = (JNIEnv*)SDL_AndroidGetJNIEnv();
@@ -94,7 +94,7 @@ public:
return (size_t)env->CallLongMethod(_zip, fileSizeMethod, (jint)index);
}
std::vector<uint8_t> GetFileData(const std::string_view& path) const override
std::vector<uint8_t> GetFileData(std::string_view path) const override
{
// retrieve the JNI environment.
JNIEnv* env = (JNIEnv*)SDL_AndroidGetJNIEnv();
@@ -113,17 +113,17 @@ public:
return std::vector<uint8_t>(dataPtr, dataPtr + dataSize);
}
void SetFileData(const std::string_view& path, std::vector<uint8_t>&& data) override
void SetFileData(std::string_view path, std::vector<uint8_t>&& data) override
{
STUB();
}
void DeleteFile(const std::string_view&) override
void DeleteFile(std::string_view) override
{
STUB();
}
void RenameFile(const std::string_view&, const std::string_view&) override
void RenameFile(std::string_view, std::string_view) override
{
STUB();
}
@@ -131,12 +131,12 @@ public:
namespace Zip
{
std::unique_ptr<IZipArchive> Open(const std::string_view& path, ZIP_ACCESS access)
std::unique_ptr<IZipArchive> Open(std::string_view path, ZIP_ACCESS access)
{
return std::make_unique<ZipArchive>(path, access);
}
std::unique_ptr<IZipArchive> TryOpen(const std::string_view& path, ZIP_ACCESS access)
std::unique_ptr<IZipArchive> TryOpen(std::string_view path, ZIP_ACCESS access)
{
std::unique_ptr<IZipArchive> result;
try