mirrors/OpenRCT2
1
0
Fork 0
mirror of https://github.com/OpenRCT2/OpenRCT2 synced 2025-12-10 09:32:29 +01:00
Code Issues Releases Wiki Activity

Rename installers and use their version info for signing

Browse Source
This commit is contained in:
Michał Janiszewski
2024-11-17 23:22:55 +01:00
parent 6071dbb6d2
commit b2093f412b
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
.github/workflows/ci.yml vendored
View File

@@ -239,6 +239,7 @@ jobs:
build-portable build-portable
build-symbols build-symbols
build-installer -i build-installer -i
echo "OPENRCT2_VERSION_EXTRA=$OPENRCT2_VERSION_EXTRA" >> "$GITHUB_ENV"
- name: Rename artifacts - name: Rename artifacts
run: | run: |
mv artifacts/openrct2-portable-*.zip artifacts/OpenRCT2-${{ needs.build_variables.outputs.name }}-windows-portable-$PLATFORM.zip mv artifacts/openrct2-portable-*.zip artifacts/OpenRCT2-${{ needs.build_variables.outputs.name }}-windows-portable-$PLATFORM.zip
@@ -270,6 +271,9 @@ jobs:
github-artifact-id: ${{ steps.upload-windows-installer-unsigned.outputs.artifact-id }} github-artifact-id: ${{ steps.upload-windows-installer-unsigned.outputs.artifact-id }}
wait-for-completion: true wait-for-completion: true
output-artifact-directory: files-signed output-artifact-directory: files-signed
parameters: |
version: "${{ env.OPENRCT2_VERSION }}${{ env.OPENRCT2_VERSION_EXTRA }}"
product: "OpenRCT2 ${{ matrix.platform }} Installer for Windows 7 and later"
- name: Upload signed installer artifact (CI) - name: Upload signed installer artifact (CI)
id: upload-windows-installer-signed id: upload-windows-installer-signed
if: ${{ needs.build_variables.outputs.sign == 'true' }} if: ${{ needs.build_variables.outputs.sign == 'true' }}

4
distribution/windows/install.nsi
View File

@@ -35,7 +35,7 @@ SetCompressor LZMA
; Version Info ; Version Info
VIProductVersion "${APPVERSIONINTERNAL}" VIProductVersion "${APPVERSIONINTERNAL}"
VIAddVersionKey "ProductName" "OpenRCT2 ${APPBITS}-bit Installer for ${SUPPORTED_OS}" VIAddVersionKey "ProductName" "OpenRCT2 ${PLATFORM} Installer for ${SUPPORTED_OS}"
VIAddVersionKey "Comments" "Installs ${APPNAMEANDVERSION}" VIAddVersionKey "Comments" "Installs ${APPNAMEANDVERSION}"
VIAddVersionKey "CompanyName" "OpenRCT2 Developers" VIAddVersionKey "CompanyName" "OpenRCT2 Developers"
VIAddVersionKey "FileDescription" "Installs ${APPNAMEANDVERSION}" VIAddVersionKey "FileDescription" "Installs ${APPNAMEANDVERSION}"
@@ -44,7 +44,7 @@ VIAddVersionKey "InternalName" "InstOpenRCT2-${APPARCH}"
VIAddVersionKey "FileVersion" "${APPVERSION}-${APPARCH}" VIAddVersionKey "FileVersion" "${APPVERSION}-${APPARCH}"
VIAddVersionKey "LegalCopyright" " " VIAddVersionKey "LegalCopyright" " "
; Main Install settings ; Main Install settings
Name "${APPNAMEANDVERSION} ${APPBITS}-bit for ${SUPPORTED_OS}" Name "${APPNAMEANDVERSION} ${PLATFORM} for ${SUPPORTED_OS}"
; NOTE: Keep trailing backslash! ; NOTE: Keep trailing backslash!
InstallDirRegKey HKLM "SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\OpenRCT2" "Install Folder" InstallDirRegKey HKLM "SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\OpenRCT2" "Install Folder"