mirror of
https://github.com/OpenRCT2/OpenRCT2
synced 2026-01-26 08:14:38 +01:00
Binpack function arguments together
Previously when the arguments of a function wouldn't fit on a single line, clang-format would put each argument on its own line instead. By enabling the binpack parameter setting, it tried to fit as many on one line as possible instead. Co-authored-by: Hielke Morsink <hielke.morsink@gmail.com>
This commit is contained in:
committed by
Hielke Morsink
parent
95ce592579
commit
b02dfdbc93
@@ -197,15 +197,8 @@ static LocationXY16 get_location()
|
||||
rct_tile_element* tileElement;
|
||||
|
||||
get_map_coordinates_from_pos_window(
|
||||
w,
|
||||
w->viewport->view_width / 2,
|
||||
w->viewport->view_height / 2,
|
||||
VIEWPORT_INTERACTION_MASK_TERRAIN,
|
||||
&mapCoord.x,
|
||||
&mapCoord.y,
|
||||
&interactionType,
|
||||
&tileElement,
|
||||
nullptr);
|
||||
w, w->viewport->view_width / 2, w->viewport->view_height / 2, VIEWPORT_INTERACTION_MASK_TERRAIN, &mapCoord.x,
|
||||
&mapCoord.y, &interactionType, &tileElement, nullptr);
|
||||
mapCoord.x -= 16;
|
||||
mapCoord.x /= 32;
|
||||
mapCoord.y -= 16;
|
||||
@@ -257,17 +250,8 @@ void window_title_command_editor_open(TitleSequence* sequence, int32_t index, bo
|
||||
|
||||
rct_widget* const viewportWidget = &window_title_command_editor_widgets[WIDX_VIEWPORT];
|
||||
viewport_create(
|
||||
window,
|
||||
window->x + viewportWidget->left + 1,
|
||||
window->y + viewportWidget->top + 1,
|
||||
viewportWidget->right - viewportWidget->left - 1,
|
||||
viewportWidget->bottom - viewportWidget->top - 1,
|
||||
0,
|
||||
0,
|
||||
0,
|
||||
0,
|
||||
0,
|
||||
-1);
|
||||
window, window->x + viewportWidget->left + 1, window->y + viewportWidget->top + 1,
|
||||
viewportWidget->right - viewportWidget->left - 1, viewportWidget->bottom - viewportWidget->top - 1, 0, 0, 0, 0, 0, -1);
|
||||
|
||||
_window_title_command_editor_index = index;
|
||||
_window_title_command_editor_insert = insert;
|
||||
@@ -410,14 +394,8 @@ static void window_title_command_editor_mousedown(rct_window* w, rct_widgetindex
|
||||
}
|
||||
|
||||
window_dropdown_show_text_custom_width(
|
||||
w->x + widget->left,
|
||||
w->y + widget->top,
|
||||
widget->bottom - widget->top + 1,
|
||||
w->colours[1],
|
||||
0,
|
||||
DROPDOWN_FLAG_STAY_OPEN,
|
||||
numItems,
|
||||
widget->right - widget->left - 3);
|
||||
w->x + widget->left, w->y + widget->top, widget->bottom - widget->top + 1, w->colours[1], 0,
|
||||
DROPDOWN_FLAG_STAY_OPEN, numItems, widget->right - widget->left - 3);
|
||||
|
||||
dropdown_set_checked(get_command_info_index(command.Type), true);
|
||||
break;
|
||||
@@ -433,14 +411,8 @@ static void window_title_command_editor_mousedown(rct_window* w, rct_widgetindex
|
||||
}
|
||||
|
||||
window_dropdown_show_text_custom_width(
|
||||
w->x + widget->left,
|
||||
w->y + widget->top,
|
||||
widget->bottom - widget->top + 1,
|
||||
w->colours[1],
|
||||
0,
|
||||
DROPDOWN_FLAG_STAY_OPEN,
|
||||
numItems,
|
||||
widget->right - widget->left - 3);
|
||||
w->x + widget->left, w->y + widget->top, widget->bottom - widget->top + 1, w->colours[1], 0,
|
||||
DROPDOWN_FLAG_STAY_OPEN, numItems, widget->right - widget->left - 3);
|
||||
|
||||
dropdown_set_checked(command.Speed - 1, true);
|
||||
}
|
||||
@@ -454,14 +426,8 @@ static void window_title_command_editor_mousedown(rct_window* w, rct_widgetindex
|
||||
}
|
||||
|
||||
window_dropdown_show_text_custom_width(
|
||||
w->x + widget->left,
|
||||
w->y + widget->top,
|
||||
widget->bottom - widget->top + 1,
|
||||
w->colours[1],
|
||||
0,
|
||||
DROPDOWN_FLAG_STAY_OPEN,
|
||||
numItems,
|
||||
widget->right - widget->left - 3);
|
||||
w->x + widget->left, w->y + widget->top, widget->bottom - widget->top + 1, w->colours[1], 0,
|
||||
DROPDOWN_FLAG_STAY_OPEN, numItems, widget->right - widget->left - 3);
|
||||
|
||||
dropdown_set_checked(command.SaveIndex, true);
|
||||
}
|
||||
@@ -772,13 +738,8 @@ static void window_title_command_editor_paint(rct_window* w, rct_drawpixelinfo*
|
||||
|
||||
// Command dropdown name
|
||||
gfx_draw_string_left_clipped(
|
||||
dpi,
|
||||
command_info.nameStringId,
|
||||
nullptr,
|
||||
w->colours[1],
|
||||
w->x + w->widgets[WIDX_COMMAND].left + 1,
|
||||
w->y + w->widgets[WIDX_COMMAND].top,
|
||||
w->widgets[WIDX_COMMAND_DROPDOWN].left - w->widgets[WIDX_COMMAND].left - 4);
|
||||
dpi, command_info.nameStringId, nullptr, w->colours[1], w->x + w->widgets[WIDX_COMMAND].left + 1,
|
||||
w->y + w->widgets[WIDX_COMMAND].top, w->widgets[WIDX_COMMAND_DROPDOWN].left - w->widgets[WIDX_COMMAND].left - 4);
|
||||
|
||||
// Label (e.g. "Location:")
|
||||
gfx_draw_string_left(dpi, command_info.descStringId, nullptr, w->colours[1], w->x + WS, w->y + BY2 - 14);
|
||||
@@ -786,13 +747,8 @@ static void window_title_command_editor_paint(rct_window* w, rct_drawpixelinfo*
|
||||
if (command.Type == TITLE_SCRIPT_SPEED)
|
||||
{
|
||||
gfx_draw_string_left_clipped(
|
||||
dpi,
|
||||
SpeedNames[command.Speed - 1],
|
||||
nullptr,
|
||||
w->colours[1],
|
||||
w->x + w->widgets[WIDX_INPUT].left + 1,
|
||||
w->y + w->widgets[WIDX_INPUT].top,
|
||||
w->widgets[WIDX_INPUT_DROPDOWN].left - w->widgets[WIDX_INPUT].left - 4);
|
||||
dpi, SpeedNames[command.Speed - 1], nullptr, w->colours[1], w->x + w->widgets[WIDX_INPUT].left + 1,
|
||||
w->y + w->widgets[WIDX_INPUT].top, w->widgets[WIDX_INPUT_DROPDOWN].left - w->widgets[WIDX_INPUT].left - 4);
|
||||
}
|
||||
if (command.Type == TITLE_SCRIPT_FOLLOW)
|
||||
{
|
||||
@@ -810,43 +766,26 @@ static void window_title_command_editor_paint(rct_window* w, rct_drawpixelinfo*
|
||||
}
|
||||
|
||||
gfx_set_dirty_blocks(
|
||||
w->x + w->widgets[WIDX_VIEWPORT].left,
|
||||
w->y + w->widgets[WIDX_VIEWPORT].top,
|
||||
w->x + w->widgets[WIDX_VIEWPORT].right,
|
||||
w->x + w->widgets[WIDX_VIEWPORT].left, w->y + w->widgets[WIDX_VIEWPORT].top, w->x + w->widgets[WIDX_VIEWPORT].right,
|
||||
w->y + w->widgets[WIDX_VIEWPORT].bottom);
|
||||
gfx_draw_string_left_clipped(
|
||||
dpi,
|
||||
spriteString,
|
||||
gCommonFormatArgs,
|
||||
colour,
|
||||
w->x + w->widgets[WIDX_VIEWPORT].left + 2,
|
||||
w->y + w->widgets[WIDX_VIEWPORT].top + 1,
|
||||
w->widgets[WIDX_VIEWPORT].right - w->widgets[WIDX_VIEWPORT].left - 2);
|
||||
dpi, spriteString, gCommonFormatArgs, colour, w->x + w->widgets[WIDX_VIEWPORT].left + 2,
|
||||
w->y + w->widgets[WIDX_VIEWPORT].top + 1, w->widgets[WIDX_VIEWPORT].right - w->widgets[WIDX_VIEWPORT].left - 2);
|
||||
}
|
||||
else if (command.Type == TITLE_SCRIPT_LOAD)
|
||||
{
|
||||
if (command.SaveIndex == SAVE_INDEX_INVALID)
|
||||
{
|
||||
gfx_draw_string_left_clipped(
|
||||
dpi,
|
||||
STR_TITLE_COMMAND_EDITOR_NO_SAVE_SELECTED,
|
||||
nullptr,
|
||||
w->colours[1],
|
||||
w->x + w->widgets[WIDX_INPUT].left + 1,
|
||||
w->y + w->widgets[WIDX_INPUT].top,
|
||||
w->widgets[WIDX_INPUT_DROPDOWN].left - w->widgets[WIDX_INPUT].left - 4);
|
||||
dpi, STR_TITLE_COMMAND_EDITOR_NO_SAVE_SELECTED, nullptr, w->colours[1], w->x + w->widgets[WIDX_INPUT].left + 1,
|
||||
w->y + w->widgets[WIDX_INPUT].top, w->widgets[WIDX_INPUT_DROPDOWN].left - w->widgets[WIDX_INPUT].left - 4);
|
||||
}
|
||||
else
|
||||
{
|
||||
set_format_arg(0, uintptr_t, (uintptr_t)_sequence->Saves[command.SaveIndex]);
|
||||
gfx_draw_string_left_clipped(
|
||||
dpi,
|
||||
STR_STRING,
|
||||
gCommonFormatArgs,
|
||||
w->colours[1],
|
||||
w->x + w->widgets[WIDX_INPUT].left + 1,
|
||||
w->y + w->widgets[WIDX_INPUT].top,
|
||||
w->widgets[WIDX_INPUT_DROPDOWN].left - w->widgets[WIDX_INPUT].left - 4);
|
||||
dpi, STR_STRING, gCommonFormatArgs, w->colours[1], w->x + w->widgets[WIDX_INPUT].left + 1,
|
||||
w->y + w->widgets[WIDX_INPUT].top, w->widgets[WIDX_INPUT_DROPDOWN].left - w->widgets[WIDX_INPUT].left - 4);
|
||||
}
|
||||
}
|
||||
else if (command.Type == TITLE_SCRIPT_LOADSC)
|
||||
@@ -854,12 +793,8 @@ static void window_title_command_editor_paint(rct_window* w, rct_drawpixelinfo*
|
||||
if (command.Scenario[0] == '\0')
|
||||
{
|
||||
gfx_draw_string_left_clipped(
|
||||
dpi,
|
||||
STR_TITLE_COMMAND_EDITOR_NO_SCENARIO_SELECTED,
|
||||
nullptr,
|
||||
w->colours[1],
|
||||
w->x + w->widgets[WIDX_INPUT].left + 1,
|
||||
w->y + w->widgets[WIDX_INPUT].top,
|
||||
dpi, STR_TITLE_COMMAND_EDITOR_NO_SCENARIO_SELECTED, nullptr, w->colours[1],
|
||||
w->x + w->widgets[WIDX_INPUT].left + 1, w->y + w->widgets[WIDX_INPUT].top,
|
||||
w->widgets[WIDX_INPUT_DROPDOWN].left - w->widgets[WIDX_INPUT].left - 4);
|
||||
}
|
||||
else
|
||||
@@ -877,13 +812,8 @@ static void window_title_command_editor_paint(rct_window* w, rct_drawpixelinfo*
|
||||
}
|
||||
set_format_arg(0, uintptr_t, name);
|
||||
gfx_draw_string_left_clipped(
|
||||
dpi,
|
||||
nameString,
|
||||
gCommonFormatArgs,
|
||||
w->colours[1],
|
||||
w->x + w->widgets[WIDX_INPUT].left + 1,
|
||||
w->y + w->widgets[WIDX_INPUT].top,
|
||||
w->widgets[WIDX_INPUT_DROPDOWN].left - w->widgets[WIDX_INPUT].left - 4);
|
||||
dpi, nameString, gCommonFormatArgs, w->colours[1], w->x + w->widgets[WIDX_INPUT].left + 1,
|
||||
w->y + w->widgets[WIDX_INPUT].top, w->widgets[WIDX_INPUT_DROPDOWN].left - w->widgets[WIDX_INPUT].left - 4);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user