From acef8a592a15186bb3206d0f8d4ff43328677efc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=CE=B6eh=20Matt?= <5415177+ZehMatt@users.noreply.github.com> Date: Wed, 27 Oct 2021 19:50:08 +0300 Subject: [PATCH] Apply review suggestion --- src/openrct2/actions/BannerPlaceAction.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/openrct2/actions/BannerPlaceAction.cpp b/src/openrct2/actions/BannerPlaceAction.cpp index 06c96ae3db..f1b21e63ae 100644 --- a/src/openrct2/actions/BannerPlaceAction.cpp +++ b/src/openrct2/actions/BannerPlaceAction.cpp @@ -61,7 +61,7 @@ GameActions::Result::Ptr BannerPlaceAction::Query() const if (!MapCheckCapacityAndReorganise(_loc)) { log_error("No free map elements."); - return MakeResult(GameActions::Status::NoFreeElements, STR_CANT_POSITION_THIS_HERE, STR_NONE); + return MakeResult(GameActions::Status::NoFreeElements, STR_CANT_POSITION_THIS_HERE, STR_TILE_ELEMENT_LIMIT_REACHED); } auto pathElement = GetValidPathElement(); @@ -87,7 +87,7 @@ GameActions::Result::Ptr BannerPlaceAction::Query() const if (HasReachedBannerLimit()) { log_error("No free banners available"); - return MakeResult(GameActions::Status::InvalidParameters, STR_TOO_MANY_BANNERS_IN_GAME, STR_NONE); + return MakeResult(GameActions::Status::InvalidParameters, STR_CANT_POSITION_THIS_HERE, STR_TOO_MANY_BANNERS_IN_GAME); } auto* bannerEntry = get_banner_entry(_bannerType); @@ -113,7 +113,7 @@ GameActions::Result::Ptr BannerPlaceAction::Execute() const if (!MapCheckCapacityAndReorganise(_loc)) { log_error("No free map elements."); - return MakeResult(GameActions::Status::NoFreeElements, STR_CANT_POSITION_THIS_HERE, STR_NONE); + return MakeResult(GameActions::Status::NoFreeElements, STR_CANT_POSITION_THIS_HERE, STR_TILE_ELEMENT_LIMIT_REACHED); } auto* bannerEntry = get_banner_entry(_bannerType); @@ -127,7 +127,7 @@ GameActions::Result::Ptr BannerPlaceAction::Execute() const if (banner == nullptr) { log_error("No free banners available"); - return MakeResult(GameActions::Status::InvalidParameters, STR_TOO_MANY_BANNERS_IN_GAME, STR_NONE); + return MakeResult(GameActions::Status::InvalidParameters, STR_CANT_POSITION_THIS_HERE, STR_TOO_MANY_BANNERS_IN_GAME); } banner->flags = 0; banner->text = {};