From 9041551b97b9fcd3d07ed0875bece534f9e6ff42 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Janiszewski?= Date: Thu, 23 Jun 2016 21:09:57 +0200 Subject: [PATCH] Guard server against null signature --- src/network/network.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/network/network.cpp b/src/network/network.cpp index 0f185b3721..21f416d563 100644 --- a/src/network/network.cpp +++ b/src/network/network.cpp @@ -1515,9 +1515,9 @@ void Network::Server_Handle_AUTH(NetworkConnection& connection, NetworkPacket& p } else { const char *signature = (const char *)packet.Read(sigsize); SDL_RWops *pubkey_rw = SDL_RWFromConstMem(pubkey, strlen(pubkey)); - if (pubkey_rw == nullptr) { + if (signature == nullptr || pubkey_rw == nullptr) { connection.AuthStatus = NETWORK_AUTH_VERIFICATIONFAILURE; - log_verbose("Signature verification failed!"); + log_verbose("Signature verification failed, invalid data!"); } else { connection.Key.LoadPublic(pubkey_rw); SDL_RWclose(pubkey_rw);