From 79552feb54adb34ebe3273a960f35788dc0559da Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Janiszewski?= Date: Fri, 23 Oct 2015 17:22:31 +0200 Subject: [PATCH] Only copy strings when they're different When called from window_loadsave_scrollmousedown, window_loadsave_populate_list will try to strncpy a string over itself. This commit prevents that. --- src/windows/loadsave.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/windows/loadsave.c b/src/windows/loadsave.c index 9e2d0e1c97..f5ebc59814 100644 --- a/src/windows/loadsave.c +++ b/src/windows/loadsave.c @@ -600,7 +600,9 @@ static void window_loadsave_populate_list(int includeNewItem, bool browsable, co char *dst, filter[MAX_PATH], subDir[MAX_PATH]; strncpy(_directory, directory, sizeof(_directory)); - strncpy(_extension, extension, sizeof(_extension)); + if (_extension != extension) { + strncpy(_extension, extension, sizeof(_extension)); + } _shortenedDirectory[0] = '\0'; strncpy(filter, directory, sizeof(filter));