mirrors/OpenRCT2
1
0
Fork 0
mirror of https://github.com/OpenRCT2/OpenRCT2 synced 2025-12-23 15:52:55 +01:00
Code Issues Releases Wiki Activity

Improve Windows implementation of ToUpper

Browse Source
This commit is contained in:
Ted John
2018-05-14 23:50:19 +01:00
committed by Aaron van Geffen
parent 085d85585a
commit 6109a9bf17
1 changed files with 34 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

73
src/openrct2/core/String.cpp
View File

@@ -667,49 +667,44 @@ namespace String
{ {
#ifdef _WIN32 #ifdef _WIN32
auto srcW = ToUtf16(src); auto srcW = ToUtf16(src);
// Measure how long the destination needs to be
auto requiredSize = LCMapStringEx(
LOCALE_NAME_INVARIANT,
LCMAP_UPPERCASE | LCMAP_LINGUISTIC_CASING,
srcW.c_str(),
(int)srcW.length(),
nullptr,
0,
nullptr,
nullptr,
0);
auto dstW = std::wstring(); auto dstW = std::wstring();
dstW.resize(requiredSize);
// Keep doubling the buffer size until transformed string fits (max 10 times) // Transform the string
size_t bufferLength = src.size(); auto result = LCMapStringEx(
for (size_t i = 0; i < 10; i++) LOCALE_NAME_INVARIANT,
LCMAP_UPPERCASE | LCMAP_LINGUISTIC_CASING,
srcW.c_str(),
(int)srcW.length(),
dstW.data(),
(int)dstW.length(),
nullptr,
nullptr,
0);
if (result == 0)
{ {
// Double buffer size // Check the error
bufferLength *= 2; auto error = GetLastError();
dstW.resize(bufferLength); log_warning("LCMapStringEx failed with %d", error);
return std::string(src);
// Transform the string }
auto result = LCMapStringEx( else
LOCALE_NAME_USER_DEFAULT, {
LCMAP_UPPERCASE | LCMAP_LINGUISTIC_CASING, return String::ToUtf8(dstW);
srcW.c_str(),
(int)srcW.length(),
dstW.data(),
(int)dstW.capacity(),
nullptr,
nullptr,
0);
if (result == 0)
{
// Check the error
auto error = GetLastError();
if (error == ERROR_INSUFFICIENT_BUFFER)
{
continue;
}
else
{
log_warning("LCMapStringEx failed with %d", error);
return std::string(src);
}
}
else
{
dstW.resize(result);
return String::ToUtf8(dstW);
}
} }
log_warning("LCMapStringEx loop exceeded");
return std::string(src);
#else #else
icu::UnicodeString str = icu::UnicodeString::fromUTF8(std::string(src)); icu::UnicodeString str = icu::UnicodeString::fromUTF8(std::string(src));
str.toUpper(); str.toUpper();