From 5744509b8780ebb2ac1390dc045b45a492512268 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=98ystein=20Dale?= Date: Wed, 18 Jul 2018 00:57:37 +0200 Subject: [PATCH] Fix memory leak in config Assigning a pointer to std::string appears to only perform a copy and does not transfer ownership of the pointer, thus the allocated memory is will never be freed. Use StringBuilder::GetStdString() to avoid the memory leak. --- src/openrct2/config/IniReader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openrct2/config/IniReader.cpp b/src/openrct2/config/IniReader.cpp index 112f37a595..5dc2233c47 100644 --- a/src/openrct2/config/IniReader.cpp +++ b/src/openrct2/config/IniReader.cpp @@ -354,7 +354,7 @@ private: sb.Append(&c, 1); } } - return std::string(sb.GetString()); + return sb.GetStdString(); } std::string GetLine(size_t index)