mirrors/OpenRCT2
1
0
Fork 0
mirror of https://github.com/OpenRCT2/OpenRCT2 synced 2025-12-22 15:23:01 +01:00
Code Issues Releases Wiki Activity

Fix #11354: Coding style causes undefined behaviour

Browse Source 
An underscore followed by a capital letter used as a prefix might cause
undefined behaviour
This commit is contained in:
Soham Roy
2021-10-05 17:28:50 +05:30
committed by GitHub
parent 36a0a28e3f
commit 4d27417fd2
8 changed files with 46 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/openrct2/interface/Window.cpp
View File

@@ -228,7 +228,7 @@ void window_close(rct_window* w)
g_window_list.erase(itWindow);
}
template<typename _TPred> static void window_close_by_condition(_TPred pred, uint32_t flags = WindowCloseFlags::None)
template<typename TPred> static void window_close_by_condition(TPred pred, uint32_t flags = WindowCloseFlags::None)
{
bool listUpdated;
do
@@ -461,7 +461,7 @@ rct_widgetindex window_find_widget_from_point(rct_window* w, const ScreenCoordsX
*
* @param window The window to invalidate (esi).
*/
template<typename _TPred> static void window_invalidate_by_condition(_TPred pred)
template<typename TPred> static void window_invalidate_by_condition(TPred pred)
{
window_visit_each([pred](rct_window* w) {
if (pred(w))
@@ -521,7 +521,7 @@ void widget_invalidate(rct_window* w, rct_widgetindex widgetIndex)
{ w->windowPos + ScreenCoordsXY{ widget.right + 1, widget.bottom + 1 } } });
}
template<typename _TPred> static void widget_invalidate_by_condition(_TPred pred)
template<typename TPred> static void widget_invalidate_by_condition(TPred pred)
{
window_visit_each([pred](rct_window* w) {
if (pred(w))