From 121f121d4ef87d5d8d00946b157a36a97abcab1a Mon Sep 17 00:00:00 2001 From: Henry Cheng <39224097+jazzysoggy@users.noreply.github.com> Date: Tue, 6 Sep 2022 17:21:22 -0400 Subject: [PATCH] #17735 Track elements are listed twice when building backwards Fix: Instead of checking whether bank has the value TRACK_BANK_UPSIDE_DOWN, instead check bank_start, as bank is not guaranteed to be bank_start. --- distribution/changelog.txt | 2 +- src/openrct2-ui/windows/RideConstruction.cpp | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/distribution/changelog.txt b/distribution/changelog.txt index c98f3d2cb1..8dee82b89a 100644 --- a/distribution/changelog.txt +++ b/distribution/changelog.txt @@ -46,7 +46,7 @@ - Fix: [#17571] All researched tracked rides show up as new vehicles in .park scenarios. - Fix: [#17600] Notifications are not properly cleared when loading a park. - Fix: [#17605] Crash when opening parks which have had objects removed externally. -- Fix: [#17639] When building upside down, the special elements list contains many items twice (original bug). +- Fix: [#17639, 17735] When building upside down, the special elements list contains many items twice (original bug). - Fix: [#17703] (undefined string) when building on invalid height. - Fix: [#17776] “Other Parks” tab uses separate lists for SC4/SC6 and .park scenarios. - Fix: [#17784] Colour preset RNG is biased (original bug). diff --git a/src/openrct2-ui/windows/RideConstruction.cpp b/src/openrct2-ui/windows/RideConstruction.cpp index 2202b8667e..970ec03e5e 100644 --- a/src/openrct2-ui/windows/RideConstruction.cpp +++ b/src/openrct2-ui/windows/RideConstruction.cpp @@ -2114,9 +2114,8 @@ public: } } } - - if ((bank == TRACK_BANK_UPSIDE_DOWN || ted.Definition.bank_end == TRACK_BANK_UPSIDE_DOWN) - && bank != _previousTrackBankEnd) + if ((ted.Definition.bank_start == TRACK_BANK_UPSIDE_DOWN || ted.Definition.bank_end == TRACK_BANK_UPSIDE_DOWN) + && (bank != _previousTrackBankEnd)) continue; _currentPossibleRideConfigurations[currentPossibleRideConfigurationIndex] = trackType;