From a2a067f0f16acb6a210d5287ff31826f8bda74bd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Janiszewski?= Date: Sat, 10 Sep 2016 21:05:40 +0200 Subject: [PATCH 1/2] Add missing virtual destructor to IStringReader --- src/core/StringReader.hpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/core/StringReader.hpp b/src/core/StringReader.hpp index 1287a5e5ef..aee09b43b9 100644 --- a/src/core/StringReader.hpp +++ b/src/core/StringReader.hpp @@ -23,6 +23,8 @@ interface IStringReader { + virtual ~IStringReader() = default; + virtual bool TryPeek(codepoint_t * outCodepoint) abstract; virtual bool TryRead(codepoint_t * outCodepoint) abstract; virtual void Skip() abstract; From 3c2569dbea969a105dadebd5cdb73dbe77ef176b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Janiszewski?= Date: Sat, 10 Sep 2016 21:06:53 +0200 Subject: [PATCH 2/2] Add -Wnon-virtual-dtor to CMakeLists.txt --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 58cc7685cf..c33c4a3c30 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -227,7 +227,7 @@ endif () # set necessary flags to compile code as is set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${TARGET_M} -std=gnu99 ${COMMON_COMPILE_OPTIONS}") -set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${TARGET_M} -std=gnu++11 ${COMMON_COMPILE_OPTIONS}") +set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${TARGET_M} -std=gnu++11 ${COMMON_COMPILE_OPTIONS} -Wnon-virtual-dtor") set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} ${TARGET_M}") set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${CMAKE_SHARED_LINKER_FLAGS} ${PIE_FLAG}")