From 03ddac9c7f1b1afe2aab9c9f63d9b5cc5d46457c Mon Sep 17 00:00:00 2001
From: Andrei BENCSIK <andrei.bencsik@gmail.com>
Date: Sun, 7 Jan 2024 00:20:03 +0200
Subject: [PATCH] Refactor GetInstallPath for linux

simplify the Platform::GetInstallPath (linux) by removing unnecessary
vector, removing unused #ifdef path and using string_views where
appropriate. no vector was actually needed as the prefixes are fixed
(same as the SearchLocations) - using a plain array avoids an
unnecessary allocation (actually a couple as the old code was using
push_back without reserve).

how it was tested?
run the game, check it finds path OK - PASS
run in the debugger, actually loop through OK - PASS
---
 src/openrct2/platform/Platform.Linux.cpp | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/src/openrct2/platform/Platform.Linux.cpp b/src/openrct2/platform/Platform.Linux.cpp
index fba489885d..516c126cfe 100644
--- a/src/openrct2/platform/Platform.Linux.cpp
+++ b/src/openrct2/platform/Platform.Linux.cpp
@@ -97,25 +97,23 @@ namespace Platform
         }
         // 2. Try {${exeDir},${cwd},/}/{data,standard system app directories}
         // exeDir should come first to allow installing into build dir
-        std::vector<std::string> prefixes;
-        auto exePath = Platform::GetCurrentExecutablePath();
-        prefixes.push_back(Path::GetDirectory(exePath));
-        prefixes.push_back(GetCurrentWorkingDirectory());
-        prefixes.push_back("/");
-        static const char* SearchLocations[] = {
+        // clang-format off
+        const std::string prefixes[]{
+            Path::GetDirectory(Platform::GetCurrentExecutablePath()),
+            GetCurrentWorkingDirectory(),
+            "/"
+        };
+        static constexpr u8string_view SearchLocations[] = {
             "/data",
             "../share/openrct2",
-#    ifdef ORCT2_RESOURCE_DIR
-            // defined in CMakeLists.txt
-            ORCT2_RESOURCE_DIR,
-#    endif // ORCT2_RESOURCE_DIR
             "/usr/local/share/openrct2",
             "/var/lib/openrct2",
             "/usr/share/openrct2",
         };
+        // clang-format on
         for (const auto& prefix : prefixes)
         {
-            for (auto searchLocation : SearchLocations)
+            for (const auto searchLocation : SearchLocations)
             {
                 auto prefixedPath = Path::Combine(prefix, searchLocation);
                 LOG_VERBOSE("Looking for OpenRCT2 data in %s", prefixedPath.c_str());